From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9c0l-0005Le-L9 for qemu-devel@nongnu.org; Thu, 17 Dec 2015 12:06:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9c0k-00042G-PP for qemu-devel@nongnu.org; Thu, 17 Dec 2015 12:06:39 -0500 References: <1450240840-563-1-git-send-email-lszhu@suse.com> From: John Snow Message-ID: <5672EB92.1000605@redhat.com> Date: Thu, 17 Dec 2015 12:06:26 -0500 MIME-Version: 1.0 In-Reply-To: <1450240840-563-1-git-send-email-lszhu@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: fix readcapacity error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Lingshan , qemu-block@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, pl@kamp.de, qemu-devel@nongnu.org, ronniesahlberg@gmail.com On 12/15/2015 11:40 PM, Zhu Lingshan wrote: > fix:The error message for readcapacity 16 incorrectly mentioned > a readcapacity 10 failure, fixed the error message. > > Signed-off-by: Zhu Lingshan > --- > block/iscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/iscsi.c b/block/iscsi.c > index bd1f1bf..eb28ddc 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -1270,7 +1270,7 @@ static void iscsi_readcapacity_sync(IscsiLun *iscsilun, Error **errp) > && retries-- > 0); > > if (task == NULL || task->status != SCSI_STATUS_GOOD) { > - error_setg(errp, "iSCSI: failed to send readcapacity10 command."); > + error_setg(errp, "iSCSI: failed to send readcapacity10/16 command"); > } else if (!iscsilun->block_size || > iscsilun->block_size % BDRV_SECTOR_SIZE) { > error_setg(errp, "iSCSI: the target returned an invalid " > Reviewed-by: John Snow