From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ciD-0000IN-5M for qemu-devel@nongnu.org; Thu, 17 Dec 2015 12:51:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9ci9-0007ya-0B for qemu-devel@nongnu.org; Thu, 17 Dec 2015 12:51:33 -0500 Received: from e38.co.us.ibm.com ([32.97.110.159]:54107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ci8-0007yV-Ox for qemu-devel@nongnu.org; Thu, 17 Dec 2015 12:51:28 -0500 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Dec 2015 10:51:27 -0700 Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id A680A19D8042 for ; Thu, 17 Dec 2015 10:39:29 -0700 (MST) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tBHHpPZE28442824 for ; Thu, 17 Dec 2015 10:51:25 -0700 Received: from d03av01.boulder.ibm.com (localhost [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tBHHpOXl015096 for ; Thu, 17 Dec 2015 10:51:24 -0700 References: <1449858642-24267-1-git-send-email-jjherne@linux.vnet.ibm.com> <87poy9rybu.fsf@blackfin.pond.sub.org> <566ED627.2030706@linux.vnet.ibm.com> <87mvtdnim6.fsf@blackfin.pond.sub.org> From: "Jason J. Herne" Message-ID: <5672F59B.7020907@linux.vnet.ibm.com> Date: Thu, 17 Dec 2015 12:49:15 -0500 MIME-Version: 1.0 In-Reply-To: <87mvtdnim6.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] checkpatch: Detect newlines in error_report and other error functions Reply-To: jjherne@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: blauwirbel@gmail.com, cornelia.huck@de.ibm.com, qemu-devel@nongnu.org On 12/14/2015 10:40 AM, Markus Armbruster wrote: > "Jason J. Herne" writes: > >> On 12/14/2015 07:47 AM, Markus Armbruster wrote: >>> "Jason J. Herne" writes: >>> >>>> We don't want newlines embedded in error messages. This seems to be a common >>>> problem with new code so let's try to catch it with checkpatch. >>>> >>>> This will not catch cases where newlines are inserted into the middle of an >>>> existing multi-line statement. But those cases should be rare. >>>> >>>> Signed-off-by: Jason J. Herne >>> ... >> But I will take a look at this series and see if we can do better :). > > Thanks! If we can't, then I'm for taking this imperfect patch, because > flagging some of these mistakes is better than flagging none. > > I won't get a chance to get back to this before the new year. So feel free to push this (unless someone objects) and I'll see what I can do about improving it in January. Happy holidays! :) -- -- Jason J. Herne (jjherne@linux.vnet.ibm.com)