From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ec1-0007uW-A0 for qemu-devel@nongnu.org; Thu, 17 Dec 2015 14:53:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9ebw-0006bR-Bn for qemu-devel@nongnu.org; Thu, 17 Dec 2015 14:53:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ebw-0006bM-5v for qemu-devel@nongnu.org; Thu, 17 Dec 2015 14:53:12 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 403F7694 for ; Thu, 17 Dec 2015 19:53:11 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-6-git-send-email-armbru@redhat.com> <5672E9E5.70004@redhat.com> <87wpsduf2i.fsf@blackfin.pond.sub.org> <5672FC0D.70300@redhat.com> <87mvt8rjcu.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <567312A2.3070503@redhat.com> Date: Thu, 17 Dec 2015 12:53:06 -0700 MIME-Version: 1.0 In-Reply-To: <87mvt8rjcu.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pt5jnavsLIS1Pl9jkGAoDQDgmT4aGi6NF" Subject: Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pt5jnavsLIS1Pl9jkGAoDQDgmT4aGi6NF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 12:00 PM, Markus Armbruster wrote: >>>>> @@ -128,6 +138,7 @@ ErrorClass error_get_class(const Error *err); >>>>> * If @errp is anything else, *@errp must be NULL. >>>>> * The new error's class is ERROR_CLASS_GENERIC_ERROR, and its >>>>> * human-readable error message is made from printf-style @fmt, ..= =2E >>>>> + * The resulting message should not contain newlines. >>>> >>>> Should we also discourage trailing punctuation? >>> >>> Yes. How to best phrase it? >> >> Maybe: >> >> The resulting message should be a single phrase, with no newline or >> trailing punctuation. >=20 > What about ending the message with an exclamation mark? Very few current users do that! An exclamation mark is still trailing punctuation! And I don't like shouting at users! :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pt5jnavsLIS1Pl9jkGAoDQDgmT4aGi6NF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcxKiAAoJEKeha0olJ0Nqyx0IAI4vJMRv/NUZ+j7Wjtw/jbDS tzNBmW69gM27Kr58vDiJIZPF0iD94bJLhPahZOVP9tdZY5IXeERHx0jB4aYncBVX E8y8Pc3SiFttA+gQoaTiCGDB+Q9OC8siyuQzyH5ogeARn8t8E0hGu3DtnE578ly+ +234xLiS8fPvYWWRxA8+BgCWlFo+RCveiax/cNacn3hCe7kGNlIUXBuwXiXG7jk1 WWWJfnMycMjNQLvMWUz0yTqPCTGahoJ/LKXNwKrkluRg3yBoP2cwIAnKrb99jQtF uTZKQivc4Ffc8BC1yE3+VFFi0PAYAi+97ItTsl7O6ak6ExyuXHmgoNbgNdHi27E= =NXJU -----END PGP SIGNATURE----- --pt5jnavsLIS1Pl9jkGAoDQDgmT4aGi6NF--