From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9eel-0001WR-GF for qemu-devel@nongnu.org; Thu, 17 Dec 2015 14:56:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9eeh-0007Is-8X for qemu-devel@nongnu.org; Thu, 17 Dec 2015 14:56:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9eeh-0007In-3i for qemu-devel@nongnu.org; Thu, 17 Dec 2015 14:56:03 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id AE825A0B2B for ; Thu, 17 Dec 2015 19:56:02 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-2-git-send-email-armbru@redhat.com> <5672EE3D.3080901@redhat.com> <87y4cssy9k.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56731351.6070206@redhat.com> Date: Thu, 17 Dec 2015 12:56:01 -0700 MIME-Version: 1.0 In-Reply-To: <87y4cssy9k.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uOp15FiRqhbVe1pm4VnjMXhtC9ADEIP95" Subject: Re: [Qemu-devel] [PATCH v2 01/23] qemu-nbd: Replace BSDism by error_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uOp15FiRqhbVe1pm4VnjMXhtC9ADEIP95 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 11:52 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> On 12/17/2015 09:49 AM, Markus Armbruster wrote: >>> Coccinelle semantic patch >>> >>> case 'k': >>> sockpath =3D optarg; >>> if (sockpath[0] !=3D '/') { >>> - errx(EXIT_FAILURE, "socket path must be absolute\n")= ; >>> + error_report("socket path must be absolute\n"); >> >> I'm guessing later in the series will kill the trailing newline? If so= , >> then this patch is fine (again, limiting to just coccinelle here). >=20 > It's a mistake-preserving patch :) As it should be. No-op automatic semantic transformations are easiest to review when they are really no-op. >=20 > It should be killed in PATCH 21, but isn't, because I forgot to run > Coccinelle again after rebasing v1 onto the patches new in v2. I'll fi= x > PATCH 21. >=20 > What about: >=20 > A few of the error messages touched have trailing newlines. They'l= l > be stripped later in this series. Works for me. >> Long source line worth wrapping? >> >> Line wraps and commit message improvements seem obvious, so I'm okay >> with adding: >> Reviewed-by: Eric Blake >=20 > Thanks! --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uOp15FiRqhbVe1pm4VnjMXhtC9ADEIP95 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcxNSAAoJEKeha0olJ0NqDE0H/2SLx/Hb0Gfs+GuEatjdjLEC CjExo/YxyjxrZtybduhhxlcAGfzYmFxrIZIK8weynBtgwkD9iKnVU3Ov9gCRR+Fj B7fQcbQp0IF9qLq/vwohScQKPGLHT0gMn3PpdCk19bbXqjsQlJzj3ppoc9bUl2Hi YxTVzI76LLtaK5SdEoUOWhsNX4Qqfu2pIi6noI0ralBFGyeW4jqEB/4a3eAao0nH aEtsljPqhePiyhiR4gxE9wk/LvJdELr9Oz5IXjL+DMlRYKaZi8c+EA+cy67jp2Nd gf23ljhesIQF9eeiVixgeZq0zxE6J/hEsyAlscC5pO4ToUw9IBslsGlFF/7Lqs0= =MDyt -----END PGP SIGNATURE----- --uOp15FiRqhbVe1pm4VnjMXhtC9ADEIP95--