From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9esu-0003gx-Px for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:10:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9esp-0002XJ-HA for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:10:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9esp-0002W9-3v for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:10:39 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id D80BEC0B2ED4 for ; Thu, 17 Dec 2015 20:10:37 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-5-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <567316B8.5080301@redhat.com> Date: Thu, 17 Dec 2015 13:10:32 -0700 MIME-Version: 1.0 In-Reply-To: <1450371004-26866-5-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UrBIWIllULpuP5w8OiX3mpdPrcN7oSnNo" Subject: Re: [Qemu-devel] [PATCH v2 04/23] error: Use error_report_err() instead of ad hoc prints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UrBIWIllULpuP5w8OiX3mpdPrcN7oSnNo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 09:49 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > contrib/ivshmem-server/main.c | 4 +--- > qdev-monitor.c | 3 +-- > qemu-nbd.c | 3 +-- > 3 files changed, 3 insertions(+), 7 deletions(-) >=20 > diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/mai= n.c > index 54ff001..00508b5 100644 > --- a/contrib/ivshmem-server/main.c > +++ b/contrib/ivshmem-server/main.c > @@ -106,9 +106,7 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, = int argc, char *argv[]) > case 'l': /* shm_size */ > parse_option_size("shm_size", optarg, &args->shm_size, &er= rp); Idea for a followup patch: The name 'errp' is most often associated with type 'Error **'; but here it is 'Error *', which is confusing. Other offenders in hmp.c, hw/core/nmi.c, include/qemu/sockets.h, and tests/test-string-output-visitor.c. > if (errp) { > - fprintf(stderr, "cannot parse shm size: %s\n", > - error_get_pretty(errp)); > - error_free(errp); > + error_report_err(errp); This loses the "cannot parse shm size: " prefix; but I don't think that hurts. Could use a mention in the commit message, though. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UrBIWIllULpuP5w8OiX3mpdPrcN7oSnNo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcxa4AAoJEKeha0olJ0NqZE8H/2RMT4jayewsF6Pexwn+8FzJ rniNcMUlifecKF9HDiU2xWHNXhPlXSXizQWIfNjgYhO8sTXOJ9U1LaUsQhh947+p Zl9EC8SXUiNJ55e+kNqj+oZMtlak7I/YdikmRtCyROqGu5H5066eIFfEtj4qnK2H 0dPiMqZYkC34RJVAF4uJxedFswXa2XhKwWiKt+MvmLjvVn4X8alcgGBrakndHEs6 52vXjKJZpTBX24T2LxTp8mFLvU6ueptypE78vUXVd/Gj1BARAbg78qWu/2f3IzeT 5XcppuFlSbLYptIGx7JCFu4nT7Z62sG8kfE/AOxnP47EpNIydhlZDs4lr1XoxEE= =VKab -----END PGP SIGNATURE----- --UrBIWIllULpuP5w8OiX3mpdPrcN7oSnNo--