From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9eyf-0005Or-R9 for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:16:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9eyc-00047q-GJ for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:16:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9eyc-00047f-7B for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:16:38 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 3BC51C0B7E09 for ; Thu, 17 Dec 2015 20:16:37 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-7-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56731824.1030106@redhat.com> Date: Thu, 17 Dec 2015 13:16:36 -0700 MIME-Version: 1.0 In-Reply-To: <1450371004-26866-7-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VlvvcjArcxSxKi8KHJXfdprCEofQe6hQn" Subject: Re: [Qemu-devel] [PATCH v2 06/23] block: Clean up "Could not create temporary overlay" error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VlvvcjArcxSxKi8KHJXfdprCEofQe6hQn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 09:49 AM, Markus Armbruster wrote: > bdrv_create() sets an error and returns -errno on failure. When the > latter is interesting, the error is created with error_setg_errno(). >=20 > bdrv_append_temp_snapshot() uses the error's message to create a new > one with error_setg_errno(). This adds a strerror() that is either > uninteresting or duplicate. Use error_setg() instead. >=20 > Signed-off-by: Markus Armbruster > --- > block.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VlvvcjArcxSxKi8KHJXfdprCEofQe6hQn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcxgkAAoJEKeha0olJ0Nqr2oH/10ECpxejoNSk2ClBnXSuvl+ 6oljzk4SHUUQD5KPihUJ/WraKHu7SsjfjbfCuG/2Rxyzzn/5fbtYt1i2LFIf/kOG OwZZaLHyetDNOeYCaSMIGE1ArkMrDTCiqKeliyolrGNzNwthjG1sYpe4pb8N6rac K/G4kgifkqrg5kuIBFxo0z1KPCrHjfnOFkS6obaY+inbxbcFqAB6eo4vXND380O0 1YPEP0C/YC7Bk7nARRCPulIiL4R4UpJ6BDIkWAGZAurikyIgArw+ggFoYPrPthuU l157w0rtU+Oz+hFjxooGiyyoO0XDG14B5RDAI64VYIxy/aZ5+SU80bdhTjhUz1o= =4eYv -----END PGP SIGNATURE----- --VlvvcjArcxSxKi8KHJXfdprCEofQe6hQn--