From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9fRU-00059R-9Q for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:46:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9fRP-0002Tx-CX for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:46:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9fRP-0002Tm-1H for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:46:23 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 930FD693DD for ; Thu, 17 Dec 2015 20:46:22 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-15-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56731F1D.4030802@redhat.com> Date: Thu, 17 Dec 2015 13:46:21 -0700 MIME-Version: 1.0 In-Reply-To: <1450371004-26866-15-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iUR6BeFK2d8ChnbLrS9rlle5e5P2mok0A" Subject: Re: [Qemu-devel] [PATCH v2 14/23] migration: Use error_reportf_err() instead of monitor_printf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iUR6BeFK2d8ChnbLrS9rlle5e5P2mok0A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 09:49 AM, Markus Armbruster wrote: > Using error_reportf_err() instead of monitor_printf() makes no > difference when monitor_printf() is used correctly, i.e. within an HMP > monitor. Elsewhere, monitor_printf() does nothing, while > error_reportf_err() reports to stderr. >=20 > Both changed functions are HMP command handlers. These should only > run within an HMP monitor. >=20 > Signed-off-by: Markus Armbruster > --- > migration/savevm.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --iUR6BeFK2d8ChnbLrS9rlle5e5P2mok0A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcx8dAAoJEKeha0olJ0NqyAQIAKFZ3aHcPDkWBUFNDGYbiEgZ BA++uCFfLZvAaOASwGT9H9faDXQSPIfK4YRGTajE2PulfXeZothGOtuWBay4c++P 9zz+Gke8CEWDxxOI2CwRkmSDvzEalpACNpNMnsRQsNe4rXOLh6JBvT1xwGd4zsGw JS/VIBrli1ZMry0gXM0uqpF8df72ar/YJGOVtr59YvHJHm/TYlUaeYo2zzpHcgJG wdhVncTPJxCO5pp/LNzclvVmFysXrhSYSK7YYHUX/wB6P3QMNJ+7PMJXhRZYBdBZ AYJBrSnAa0xEKxUXFqe81BQe+30EbsTJPqKyHjPio4Qbi4ajxU0qA3PWKqsxkOw= =dzbA -----END PGP SIGNATURE----- --iUR6BeFK2d8ChnbLrS9rlle5e5P2mok0A--