From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9fWk-0007fs-Se for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:51:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9fWf-0003nN-RQ for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:51:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9fWf-0003nJ-LV for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:51:49 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 98581A99A for ; Thu, 17 Dec 2015 20:51:48 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-16-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56732063.7080708@redhat.com> Date: Thu, 17 Dec 2015 13:51:47 -0700 MIME-Version: 1.0 In-Reply-To: <1450371004-26866-16-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C5l6A9J2We3todmW2iGhsBjsbiu1SopD9" Subject: Re: [Qemu-devel] [PATCH v2 15/23] qemu-io qemu-nbd: Use error_report() etc. instead of fprintf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C5l6A9J2We3todmW2iGhsBjsbiu1SopD9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 09:49 AM, Markus Armbruster wrote: > Just three instances left. >=20 > Signed-off-by: Markus Armbruster > --- > +++ b/qemu-nbd.c > @@ -257,7 +257,7 @@ static void *nbd_client_thread(void *arg) > fd =3D open(device, O_RDWR); > if (fd < 0) { > /* Linux-only, we can use %m in printf. */ > - fprintf(stderr, "Failed to open %s: %m\n", device); > + error_report("Failed to open %s: %m", device); I asked back in 1/20 if we want to add error_report_errno() - if so, it would let us switch from the comment about non-portable use of %m over to using that new function. Of course, doesn't affect _this_ patch. Lots of test fallout from those three conversions, but they look fine. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --C5l6A9J2We3todmW2iGhsBjsbiu1SopD9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcyBjAAoJEKeha0olJ0NqwB4H/jzNZ5HbnWccLrHUbPbI6amB hR+C6JLbFqwIg/hhNKXUpHfz+a+/tcrftFgAQRZwVFzQUuGqHTrZ9D/qWVsZb0nQ s/dX54zN954ENitdQvpCrK+1yNxGxLPSqiUziYfQv9GzIF9CBgahdybrlVBlpetZ OZbxy4mtSl8EAMNQDLAeaqNFsF6JgHPLSLo5CgP/AhTKzvL/o0/moDlAO4vnCnZ6 S7Kv2w1hWjkw5qfFGaRkNJmgzY5Zinfq9Z3aZb3e6ihkz7/i7MyqAjm2OUir85v+ XcKnqGZt7oNdzKbgWwuT+Kml8pe83ogakuHrZjbKAmVlIVeFcENU+dtukhBpzhI= =onUn -----END PGP SIGNATURE----- --C5l6A9J2We3todmW2iGhsBjsbiu1SopD9--