From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9fbs-00050w-3c for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:57:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9fbo-00057I-4b for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:57:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9fbn-000575-UT for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:57:08 -0500 References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-17-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <567321A1.3070808@redhat.com> Date: Thu, 17 Dec 2015 13:57:05 -0700 MIME-Version: 1.0 In-Reply-To: <1450371004-26866-17-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Dtt685O9M8aA5FPEnbC9EkTpVBacw9wkQ" Subject: Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: Fam Zheng , zhanghailiang , Stefan Berger , Markus Armbruster , Pavel Fedin , "Dr. David Alan Gilbert" , Dominik Dingel , David Hildenbrand , Peter Crosthwaite , "Jason J. Herne" , Bharata B Rao , Changchun Ouyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Dtt685O9M8aA5FPEnbC9EkTpVBacw9wkQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 09:49 AM, Markus Armbruster wrote: > Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they > keep coming back. Tracked down with the Coccinelle semantic patch > from commit 312fd5f. Don't forget to rerun this to pick up stragglers exposed by 1/23 :) > Signed-off-by: Markus Armbruster > Reviewed-by: Dr. David Alan Gilbert > Acked-by: Cornelia Huck > Acked-by: Bharata B Rao > Acked-by: Fam Zheng If you want to add to the list: Reviewed-by: Eric Blake > +++ b/hw/s390x/s390-skeys.c > @@ -191,8 +191,8 @@ static int qemu_s390_skeys_set(S390SKeysState *ss, = uint64_t start_gfn, > /* Check for uint64 overflow and access beyond end of key data */ > if (start_gfn + count > skeydev->key_count || start_gfn + count < = count) { > error_report("Error: Setting storage keys for page beyond the = end " > - "of memory: gfn=3D%" PRIx64 " count=3D%" PRId64 "\n", = start_gfn, > - count); > + "of memory: gfn=3D%" PRIx64 " count=3D%" PRId64, > + start_gfn, count); Do we want a separate patch cleaning up 'Error: ' prefixes? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Dtt685O9M8aA5FPEnbC9EkTpVBacw9wkQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcyGhAAoJEKeha0olJ0Nqo+EH/1ad655u6Utht0kO7e4b2P9r GmP+7cXuOF8nF8+Ab3szutbrDm63D5Dq0NudJJsLUsiMs9wVOs0PVL1qZec9jbH8 aEcaWLXuX7vkdhEy0rzbUt8VbPT5WbcWkaucFDNVQe4dewZuahM+DqsNOnX19Idm RaOeB3ncVPVzfpk/uJkCvSx0gpxJFTZURk46g8b5LyyEcOjN4gWde2QvL5OgD9J4 zm1iiKkHByHQvBVJx1dIUCBQfSba7gNKncjRS4PtD6HgeiBFxjXCPaKuh+h1wnbA T6sszVX3NSUyi4Pmp4hSHDLIQQr34CxARdEnenl8l4w+JnV5qKzWl5QeqOMYtDQ= =9OrI -----END PGP SIGNATURE----- --Dtt685O9M8aA5FPEnbC9EkTpVBacw9wkQ--