From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9fc5-0005RB-By for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:57:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9fc1-0005AG-AZ for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:57:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9fc1-0005AB-5I for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:57:21 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id B7309C00126D for ; Thu, 17 Dec 2015 20:57:20 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-16-git-send-email-armbru@redhat.com> <56732063.7080708@redhat.com> From: Eric Blake Message-ID: <567321AF.60708@redhat.com> Date: Thu, 17 Dec 2015 13:57:19 -0700 MIME-Version: 1.0 In-Reply-To: <56732063.7080708@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OU4iDokDqLPD4ualpV95okUdf5jPFtcIa" Subject: Re: [Qemu-devel] [PATCH v2 15/23] qemu-io qemu-nbd: Use error_report() etc. instead of fprintf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OU4iDokDqLPD4ualpV95okUdf5jPFtcIa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 01:51 PM, Eric Blake wrote: > On 12/17/2015 09:49 AM, Markus Armbruster wrote: >> Just three instances left. >> >> Signed-off-by: Markus Armbruster >> --- >=20 >> +++ b/qemu-nbd.c >> @@ -257,7 +257,7 @@ static void *nbd_client_thread(void *arg) >> fd =3D open(device, O_RDWR); >> if (fd < 0) { >> /* Linux-only, we can use %m in printf. */ >> - fprintf(stderr, "Failed to open %s: %m\n", device); >> + error_report("Failed to open %s: %m", device); >=20 > I asked back in 1/20 if we want to add error_report_errno() - if so, it= I meant 1/23. > would let us switch from the comment about non-portable use of %m over > to using that new function. Of course, doesn't affect _this_ patch. >=20 > Lots of test fallout from those three conversions, but they look fine. >=20 > Reviewed-by: Eric Blake >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OU4iDokDqLPD4ualpV95okUdf5jPFtcIa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcyGwAAoJEKeha0olJ0NqjmsIAIrfDFb9EFe8rMKxGmCzU0R7 mNCwE6qAcFSZrw3LmcQFUuixonKiHLjb5RqrklYbEW/uFDNeyccqy7n9czGgUY5r 40226i0/fI7hnDhaym4dFzf3xQ3sxVJLa+pXKg8tGuGwiJTMcsbelkbtJbn+i747 jP/eIOoF9+fGJptlN1F9qHBX/B4d2sUos1Ch1Sg87U3m5fyzjKwKNEkdJ0ILeMJz 4GRvFGexXXf3FKrcFXlfZ9QG4R0RPo4YBTB5zR85NPhkO4R2XNEYhaTmbzB09z6v 7gW3tP5RdVFXzp2nv4yGQDRVj4/kFW9RP03fVXMjvwhNzTFNtFCMjg/SaNkCAtw= =aH5i -----END PGP SIGNATURE----- --OU4iDokDqLPD4ualpV95okUdf5jPFtcIa--