From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ff5-0002gb-QE for qemu-devel@nongnu.org; Thu, 17 Dec 2015 16:00:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9ff1-0006Ds-Mb for qemu-devel@nongnu.org; Thu, 17 Dec 2015 16:00:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ff1-0006Do-II for qemu-devel@nongnu.org; Thu, 17 Dec 2015 16:00:27 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 28D1A96CD for ; Thu, 17 Dec 2015 21:00:27 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-18-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <5673226A.6050205@redhat.com> Date: Thu, 17 Dec 2015 14:00:26 -0700 MIME-Version: 1.0 In-Reply-To: <1450371004-26866-18-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="I0dXQJmjHdUT5BTEJbMXSnMI8WhqJo29E" Subject: Re: [Qemu-devel] [PATCH v2 17/23] vmdk: Clean up control flow in vmdk_parse_extents() a bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: Fam Zheng This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --I0dXQJmjHdUT5BTEJbMXSnMI8WhqJo29E Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 09:49 AM, Markus Armbruster wrote: > Cc: Fam Zheng > Signed-off-by: Markus Armbruster > --- > block/vmdk.c | 28 +++++++++++++++------------- > 1 file changed, 15 insertions(+), 13 deletions(-) Could have mentioned what the change was: factoring out a common next_line() helper to let you drop an end-of-loop label. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --I0dXQJmjHdUT5BTEJbMXSnMI8WhqJo29E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcyJqAAoJEKeha0olJ0NqzY8H/i+5Td0qCGZP7JvdCQvlUmwc oGiboaF2k1tVaUmkwkc6zQ1iP5T1YXpEeydAjdeitYTHA01Nqqe9ETJasuvBldTu 0eMw7K+nn3juJgZCHlcym3hXhqDC2DwEHrL+irVlHk9z0QI1261N4mLGkBkXjO8R PGzrXc3BwVZnhRp/26a4D7lt3K0BOWic7LeeDCaLsBJpkXZHSjd26rU57O/Hrg0S CcwJ7N3s/oZxJnxpoN8QdpDlXYht5hhH+B1b50X33nWFmXxyMVUG98VyPrxOheT4 LrIe34CaE7itncILKI3XAhefOmnz47eLKDxiYBfB78xITkQirGLvgXNidg5RyD0= =tZDI -----END PGP SIGNATURE----- --I0dXQJmjHdUT5BTEJbMXSnMI8WhqJo29E--