From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9gMm-00067s-Ry for qemu-devel@nongnu.org; Thu, 17 Dec 2015 16:45:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9gMi-0008Tu-QD for qemu-devel@nongnu.org; Thu, 17 Dec 2015 16:45:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9gMi-0008Tm-BW for qemu-devel@nongnu.org; Thu, 17 Dec 2015 16:45:36 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id CA1DCAC7C9 for ; Thu, 17 Dec 2015 21:45:35 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-20-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56732CFE.7040909@redhat.com> Date: Thu, 17 Dec 2015 14:45:34 -0700 MIME-Version: 1.0 In-Reply-To: <1450371004-26866-20-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CJog3N1UjARJxb66d18NXVWNKdd0VrMuv" Subject: Re: [Qemu-devel] [PATCH v2 19/23] pci-assign: Clean up "Failed to assign" error messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: Laszlo Ersek This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CJog3N1UjARJxb66d18NXVWNKdd0VrMuv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 09:50 AM, Markus Armbruster wrote: > The arguments of error_setg() & friends should yield a short error > string without newlines. >=20 > Two places try to append additional help to the error message by > embedding newlines in the error string. That's nice, but let's do it > the right way, with error_append_hint(). >=20 > Cc: Laszlo Ersek > Signed-off-by: Markus Armbruster > --- > hw/i386/kvm/pci-assign.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CJog3N1UjARJxb66d18NXVWNKdd0VrMuv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcyz+AAoJEKeha0olJ0Nq+VEIAK7zklZ/SMqBI3s8BdJVyoCq rpk6BfiGlJxq0VC9Jb5kLZdn0ZwQuV1CnzZc2zbN8NRoBfUJubUYAInd/iH+Rdne MHdrzOjasiN1mK1QsGXqR36mGEZHuReTBIleOxIR1jio/hRIkdDEQKAAW4Mx2mWh tkEtNIOLmoGlxlLnEvHnp/sVosN5qER8YA4q27KlBmAPnkxWte1bk47XdbGoigs8 r5AG6H3x7+md1lE8gfQilo/mjpiDYoxHtEWxYgQq3OCKie4B5w9D/Sg14YM142+r DnBTmwB1L1iyTvOlPfGU3sFXlKtzZj/GYv/m2Vsi5fmzFvwbbaqNxpr1+d/s0xI= =mlIQ -----END PGP SIGNATURE----- --CJog3N1UjARJxb66d18NXVWNKdd0VrMuv--