From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9gUl-0003bV-C8 for qemu-devel@nongnu.org; Thu, 17 Dec 2015 16:53:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9gUh-0001Sh-B1 for qemu-devel@nongnu.org; Thu, 17 Dec 2015 16:53:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9gUh-0001Sd-5w for qemu-devel@nongnu.org; Thu, 17 Dec 2015 16:53:51 -0500 References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-22-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56732EED.9020702@redhat.com> Date: Thu, 17 Dec 2015 14:53:49 -0700 MIME-Version: 1.0 In-Reply-To: <1450371004-26866-22-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6nTeRDmGEvQn9ofttjBuc4cs0NAprWVSt" Subject: Re: [Qemu-devel] [PATCH v2 21/23] error: Clean up errors with embedded newlines (again) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: Laszlo Ersek , Markus Armbruster , Pavel Fedin This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6nTeRDmGEvQn9ofttjBuc4cs0NAprWVSt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 09:50 AM, Markus Armbruster wrote: > The arguments of error_report() should yield a short error string > without newlines. >=20 > A few places try to print additional help after the error message by > embedding newlines in the error string. That's nice, but let's do it > the right way. Commit 474c213 cleaned up some, but they keep coming > back. Offenders tracked down with the Coccinelle semantic patch from > commit 312fd5f. Not sure if you'll have any stragglers from 1/23 here, after fixing 16/23= =2E >=20 > Cc: Laszlo Ersek > Cc: Pavel Fedin > Signed-off-by: Markus Armbruster > Reviewed-by: Laszlo Ersek > --- > hw/i386/pc.c | 4 ++-- > kvm-all.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6nTeRDmGEvQn9ofttjBuc4cs0NAprWVSt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcy7tAAoJEKeha0olJ0NqFNIH/ivVNollZBLHvLWVZXA+Tjzs yEzdcO0moBaLm3yf/z0pGut3byKQQgYHZ9XfIltYwYUUFInQ8k814Qm+AByZ3NYA VWaOCZdnQbNb8pugJhwTCcZtLVLsn8v+x3MrZiNbM0sWGAyqYyvPN3+nfQJNyMhN /WeQVy2uovxLcG6SS5Ubo02YgUxwepizprdtT/6brA/FxQqNhNjOGa6/ezUoaxiH iEeNISjZ8+iuYAo+YH/6LIAAoA6M0ww7YUA7pnHIary2Vob1PW53mSUF76H02Au0 Ft/0eCj/W9CepGDRT/dvvuZ3jxOCwABjioKXsYICvuRTzuXkzcGQ+8AdGru7cs8= =wENg -----END PGP SIGNATURE----- --6nTeRDmGEvQn9ofttjBuc4cs0NAprWVSt--