From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9qLT-0007JF-GQ for qemu-devel@nongnu.org; Fri, 18 Dec 2015 03:25:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9qLP-0007HJ-G3 for qemu-devel@nongnu.org; Fri, 18 Dec 2015 03:24:59 -0500 References: <1450425454-12274-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Cao jin Message-ID: <5673C352.70006@cn.fujitsu.com> Date: Fri, 18 Dec 2015 16:26:58 +0800 MIME-Version: 1.0 In-Reply-To: <1450425454-12274-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Use macro instead of plain text List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, mst@redhat.com, ehabkost@redhat.com, rth@twiddle.net Sorry, it can`t pass compilation... I will give v2 soon. On 12/18/2015 03:57 PM, Cao jin wrote: > There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems these two > places are missed. > > Signed-off-by: Cao jin > --- > hw/i386/pc_q35.c | 2 +- > qdev-monitor.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 9a12068..aa34a07 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -249,7 +249,7 @@ static void pc_q35_init(MachineState *machine) > ahci = pci_create_simple_multifunction(host_bus, > PCI_DEVFN(ICH9_SATA1_DEV, > ICH9_SATA1_FUNC), > - true, "ich9-ahci"); > + true, TYPE_ICH9_AHCI); > idebus[0] = qdev_get_child_bus(&ahci->qdev, "ide.0"); > idebus[1] = qdev_get_child_bus(&ahci->qdev, "ide.1"); > g_assert(MAX_SATA_PORTS == ICH_AHCI(ahci)->ahci.ports); > diff --git a/qdev-monitor.c b/qdev-monitor.c > index a35098f..f249603 100644 > --- a/qdev-monitor.c > +++ b/qdev-monitor.c > @@ -48,7 +48,7 @@ static const QDevAlias qdev_alias_table[] = { > { "virtio-net-ccw", "virtio-net", QEMU_ARCH_S390X }, > { "virtio-serial-ccw", "virtio-serial", QEMU_ARCH_S390X }, > { "lsi53c895a", "lsi" }, > - { "ich9-ahci", "ahci" }, > + { TYPE_ICH9_AHCI, "ahci" }, > { "kvm-pci-assign", "pci-assign" }, > { "e1000", "e1000-82540em" }, > { } > -- Yours Sincerely, Cao Jin