From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58488)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a9ue7-0000kJ-TO
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:00:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a9ue3-00084C-QY
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:00:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36457)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a9ue3-000842-L7
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:00:27 -0500
References: <1450423803-12839-1-git-send-email-shmulik.ladkani@ravellosystems.com>
	<1450423803-12839-2-git-send-email-shmulik.ladkani@ravellosystems.com>
	<20151218103723.13ee3db2.cornelia.huck@de.ibm.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56740367.6000104@redhat.com>
Date: Fri, 18 Dec 2015 14:00:23 +0100
MIME-Version: 1.0
In-Reply-To: <20151218103723.13ee3db2.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] compat: Introduce HW_COMPAT_2_5
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Cc: Jason Wang <jasowang@redhat.com>, idan.brown@ravellosystems.com, qemu-devel@nongnu.org, Dmitry Fleytman <dmitry@daynix.com>, David Gibson <david@gibson.dropbear.id.au>



On 18/12/2015 10:37, Cornelia Huck wrote:
> On Fri, 18 Dec 2015 09:30:02 +0200
> Shmulik Ladkani <shmulik.ladkani@ravellosystems.com> wrote:
> 
>> Introduce the place-holder for 2.5 back-compat properties, and the
>> accompanying PC_COMPAT_2_5, CCW_COMPAT_2_5, SPAPR_COMPAT_2_5.
>>
>> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
>> ---
>>  hw/i386/pc_piix.c          | 1 +
>>  hw/i386/pc_q35.c           | 1 +
>>  hw/ppc/spapr.c             | 9 +++++++++
>>  hw/s390x/s390-virtio-ccw.c | 9 +++++++++
>>  include/hw/compat.h        | 3 +++
>>  include/hw/i386/pc.h       | 4 ++++
>>  6 files changed, 27 insertions(+)
>>
> 
>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
>> index 5a52ff2..3d79654 100644
>> --- a/hw/s390x/s390-virtio-ccw.c
>> +++ b/hw/s390x/s390-virtio-ccw.c
>> @@ -235,7 +235,11 @@ static const TypeInfo ccw_machine_info = {
>>      },
>>  };
>>
>> +#define CCW_COMPAT_2_5 \
>> +        HW_COMPAT_2_5
>> +
>>  #define CCW_COMPAT_2_4 \
>> +        CCW_COMPAT_2_5 \
>>          HW_COMPAT_2_4 \
>>          {\
>>              .driver   = TYPE_S390_SKEYS,\
>> @@ -296,10 +300,15 @@ static const TypeInfo ccw_machine_2_4_info = {
>>  static void ccw_machine_2_5_class_init(ObjectClass *oc, void *data)
>>  {
>>      MachineClass *mc = MACHINE_CLASS(oc);
>> +    static GlobalProperty compat_props[] = {
>> +        CCW_COMPAT_2_5
>> +        { /* end of list */ }
>> +    };
>>
>>      mc->alias = "s390-ccw-virtio";
>>      mc->desc = "VirtIO-ccw based S390 machine v2.5";
>>      mc->is_default = 1;
>> +    mc->compat_props = compat_props;
>>  }
>>
>>  static const TypeInfo ccw_machine_2_5_info = {
> 
> s390x part:
> 
> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> 
> <There will be interaction with my patch introducing the ccw 2.6
> machine, but nothing that isn't sorted out easily>
> 

Feel free to include these in your pull request if it's coming before
say January 6th.

Paolo