From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9uhC-0003nJ-Di for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:03:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9uh6-0000Sp-Pa for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:03:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9uh6-0000Sl-Jr for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:03:36 -0500 References: <1450443571-14621-1-git-send-email-peter.maydell@linaro.org> From: Paolo Bonzini Message-ID: <56740424.6050506@redhat.com> Date: Fri, 18 Dec 2015 14:03:32 +0100 MIME-Version: 1.0 In-Reply-To: <1450443571-14621-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: Don't allow special cases of unspaced operators List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Blue Swirl , patches@linaro.org On 18/12/2015 13:59, Peter Maydell wrote: > The checkpatch.pl script has a special case to permit the following > operators to have no spaces around them: > << >> & ^ | + - * / % > > QEMU style prefers all operators to consistently have spacing around > them, so remove this special case handling. This avoids reviewers > having to manually note it during code review. > > Signed-off-by: Peter Maydell > --- > I actually thought failing to point out the lack of spaces was > a checkpatch parsing bug until I looked in the source and found it > was deliberate... > > I say "QEMU style prefers", but possibly what I actually mean is > "I prefer" ? Does anybody want to defend the unspaced versions? No thanks. Let's save to bikeshedding for important stuff such as line lengths. :) Paolo > scripts/checkpatch.pl | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index b0f6e11..efca817 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1890,19 +1890,6 @@ sub process { > ERROR("space prohibited after that '$op' $at\n" . $hereptr); > } > > - > - # << and >> may either have or not have spaces both sides > - } elsif ($op eq '<<' or $op eq '>>' or > - $op eq '&' or $op eq '^' or $op eq '|' or > - $op eq '+' or $op eq '-' or > - $op eq '*' or $op eq '/' or > - $op eq '%') > - { > - if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { > - ERROR("need consistent spacing around '$op' $at\n" . > - $hereptr); > - } > - > # A colon needs no spaces before when it is > # terminating a case value or a label. > } elsif ($opv eq ':C' || $opv eq ':L') { >