From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage
Date: Fri, 18 Dec 2015 14:08:07 +0100 [thread overview]
Message-ID: <56740537.9010106@redhat.com> (raw)
In-Reply-To: <20151218130555.GB7228@redhat.com>
On 18/12/2015 14:05, Daniel P. Berrange wrote:
> > > +
> > > +cs-glib-syms:
> > > + @perl scripts/glib-syms.pl $(GLIB_SYMS_LIST) $(C_CODE_FILES)
> >
> >
> > Does this need to be included, or could it be a separate Makefile
> > invoked with e.g. make -f scripts/Makefile.style?
>
> Any particular reason to favour that over include ? I did it this
> way because QEMU in general seems to be biased towards includes
> and not recursive make
That would not be recursive make, but rather a completely separate
Makefile to be manually invoked with -f.
Paolo
next prev parent reply other threads:[~2015-12-18 13:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 11:36 [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage Daniel P. Berrange
2015-12-18 12:36 ` Paolo Bonzini
2015-12-18 13:05 ` Daniel P. Berrange
2015-12-18 13:08 ` Paolo Bonzini [this message]
2015-12-18 13:35 ` Dr. David Alan Gilbert
2015-12-18 13:37 ` Daniel P. Berrange
2015-12-18 13:42 ` Dr. David Alan Gilbert
2015-12-18 13:49 ` Peter Maydell
2015-12-18 13:52 ` Dr. David Alan Gilbert
2015-12-18 13:41 ` Paolo Bonzini
2015-12-18 13:43 ` Peter Maydell
2015-12-18 14:49 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56740537.9010106@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).