From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ula-0006rR-Kl for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:08:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9ulW-0001of-HV for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:08:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49558) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ulW-0001ob-Bn for qemu-devel@nongnu.org; Fri, 18 Dec 2015 08:08:10 -0500 References: <1450438575-21613-1-git-send-email-berrange@redhat.com> <5673FDB0.6040900@redhat.com> <20151218130555.GB7228@redhat.com> From: Paolo Bonzini Message-ID: <56740537.9010106@redhat.com> Date: Fri, 18 Dec 2015 14:08:07 +0100 MIME-Version: 1.0 In-Reply-To: <20151218130555.GB7228@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Peter Maydell , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" On 18/12/2015 14:05, Daniel P. Berrange wrote: > > > + > > > +cs-glib-syms: > > > + @perl scripts/glib-syms.pl $(GLIB_SYMS_LIST) $(C_CODE_FILES) > > > > > > Does this need to be included, or could it be a separate Makefile > > invoked with e.g. make -f scripts/Makefile.style? > > Any particular reason to favour that over include ? I did it this > way because QEMU in general seems to be biased towards includes > and not recursive make That would not be recursive make, but rather a completely separate Makefile to be manually invoked with -f. Paolo