From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 24/24] error: Consistently name Error * objects err, and not errp
Date: Fri, 18 Dec 2015 09:11:33 -0700 [thread overview]
Message-ID: <56743035.1040306@redhat.com> (raw)
In-Reply-To: <1450452927-8346-25-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
On 12/18/2015 08:35 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> contrib/ivshmem-server/main.c | 8 ++++----
> hmp.c | 32 ++++++++++++++++----------------
> hw/core/nmi.c | 10 +++++-----
> include/qemu/sockets.h | 2 +-
> tests/test-string-output-visitor.c | 6 +++---
> 5 files changed, 29 insertions(+), 29 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-12-18 16:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 15:35 [Qemu-devel] [PATCH v3 00/24] Error reporting cleanups and fixes Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 01/24] qemu-nbd: Replace BSDism <err.h> by error_report() Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 02/24] error: Use error_report_err() where appropriate (again) Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 03/24] error: Use error_report_err() instead of monitor_printf() Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 04/24] error: Use error_report_err() instead of ad hoc prints Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 05/24] error: Improve documentation Markus Armbruster
2015-12-18 15:51 ` Eric Blake
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 06/24] block: Clean up "Could not create temporary overlay" error message Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 07/24] qemu-nbd: Clean up "Failed to load snapshot" " Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 08/24] test-throttle: Simplify qemu_init_main_loop() error handling Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 09/24] error: New error_prepend(), error_reportf_err() Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 10/24] error: Don't decorate original error message when adding to it Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 11/24] error: Use error_reportf_err() where it makes obvious sense Markus Armbruster
2015-12-18 16:08 ` Eric Blake
2015-12-18 16:22 ` Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 12/24] error: Use error_prepend() " Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 13/24] spapr: Use error_reportf_err() Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 14/24] migration: Use error_reportf_err() instead of monitor_printf() Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 15/24] qemu-io qemu-nbd: Use error_report() etc. instead of fprintf() Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 16/24] error: Strip trailing '\n' from error string arguments (again) Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 17/24] vmdk: Clean up control flow in vmdk_parse_extents() a bit Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 18/24] vmdk: Clean up "Invalid extent lines" error message Markus Armbruster
2015-12-22 1:30 ` Fam Zheng
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 19/24] pci-assign: Clean up "Failed to assign" error messages Markus Armbruster
2016-01-04 15:44 ` Laszlo Ersek
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 20/24] vhdx: Fix "log that needs to be replayed" error message Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 21/24] error: Clean up errors with embedded newlines (again) Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 22/24] hw/s390x: Rename local variables Error *l_err to just err Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 23/24] s390/sclp: Simplify control flow in sclp_realize() Markus Armbruster
2015-12-18 15:35 ` [Qemu-devel] [PATCH v3 24/24] error: Consistently name Error * objects err, and not errp Markus Armbruster
2015-12-18 16:11 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56743035.1040306@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).