From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aA3Dj-0001NM-Nc for qemu-devel@nongnu.org; Fri, 18 Dec 2015 17:09:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aA3Dg-0004uA-Fd for qemu-devel@nongnu.org; Fri, 18 Dec 2015 17:09:51 -0500 Received: from smtpbg64.qq.com ([103.7.28.238]:1087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aA3Df-0004u4-FI for qemu-devel@nongnu.org; Fri, 18 Dec 2015 17:09:48 -0500 Message-ID: <567484D5.7050203@qq.com> Date: Sat, 19 Dec 2015 06:12:37 +0800 From: Chen Gang MIME-Version: 1.0 References: <5673A718.40103@emindsoft.com.cn> <5673D3C4.8020308@vivier.eu> <56747D48.3090801@qq.com> <56748181.8050107@vivier.eu> In-Reply-To: <56748181.8050107@vivier.eu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Notice about lock bitmask translation for fcntl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , Chen Gang , riku.voipio@iki.fi Cc: Peter Maydell , qemu-devel , Richard Henderson On 12/19/15 05:58, Laurent Vivier wrote: > > Le 18/12/2015 22:40, Chen Gang a écrit : >> [...] >> I did not get any script/checkpatch.pl complains, originally. >> >> Does my email client configuration is incorrect, then cause incorrect >> mail format? I guess not. The related reason is below. >> >> - I copy your full reply mail contents to a new file (diff.patch). > > If you copy, you loose the special characters. I do a "Save as". > >> >> - Remove all '> ' in vi editor (1,% s/^> //g) (so get the original >> patch contents). >> >> - ./script/checkpatch.pl diff.patch, it has no any complains. > > If I run "file" on the saved file, I have: > > $ file orig.eml > orig.eml: SMTP mail, ASCII text, with CRLF line terminators > > I can convert it with "tr": > > $ tr "\r" "\n" < orig.eml > new.eml > > $ file new.eml > new.eml: SMTP mail, ASCII text > > $ ./scripts/checkpatch.pl new.eml > total: 0 errors, 0 warnings, 54 lines checked > > new.eml has no obvious style problems and is ready for submission. > > Laurent > OK, thank you very much. I shall config my email client again to notice about it. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed.