From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35489)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1aA3Jj-000365-Gl
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 17:16:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1aA3Jg-00072D-9U
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 17:16:03 -0500
Received: from mout.kundenserver.de ([212.227.126.134]:50988)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laurent@vivier.eu>) id 1aA3Jg-00071c-0F
	for qemu-devel@nongnu.org; Fri, 18 Dec 2015 17:16:00 -0500
References: <5673A718.40103@emindsoft.com.cn> <5673D3C4.8020308@vivier.eu>
	<56747D48.3090801@qq.com> <56748181.8050107@vivier.eu>
	<567484D5.7050203@qq.com>
From: Laurent Vivier <laurent@vivier.eu>
Message-ID: <5674858D.5050803@vivier.eu>
Date: Fri, 18 Dec 2015 23:15:41 +0100
MIME-Version: 1.0
In-Reply-To: <567484D5.7050203@qq.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Notice about lock
 bitmask translation for fcntl
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Gang <gang.chen.5i5j@qq.com>, Chen Gang <gang.chen.5i5j@gmail.com>, riku.voipio@iki.fi
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>



Le 18/12/2015 23:12, Chen Gang a écrit :
> 
> On 12/19/15 05:58, Laurent Vivier wrote:
>>
>> Le 18/12/2015 22:40, Chen Gang a écrit :
>>>
> 
> [...]
> 
>>> I did not get any script/checkpatch.pl complains, originally.
>>>
>>> Does my email client configuration is incorrect, then cause incorrect
>>> mail format? I guess not. The related reason is below.
>>>
>>>  - I copy your full reply mail contents to a new file (diff.patch).
>>
>> If you copy, you loose the special characters. I do a "Save as".
>>
>>>
>>>  - Remove all '> ' in vi editor (1,% s/^> //g) (so get the original
>>>    patch contents).
>>>
>>>  - ./script/checkpatch.pl diff.patch, it has no any complains.
>>
>> If I run "file" on the saved file, I have:
>>
>>     $ file orig.eml
>>     orig.eml: SMTP mail, ASCII text, with CRLF line terminators
>>
>> I can convert it with "tr":
>>
>>     $ tr "\r" "\n" < orig.eml > new.eml
>>
>>     $ file new.eml
>>     new.eml: SMTP mail, ASCII text
>>
>>     $ ./scripts/checkpatch.pl new.eml
>>     total: 0 errors, 0 warnings, 54 lines checked
>>
>>     new.eml has no obvious style problems and is ready for submission.
>>
>> Laurent
>>
> 
> OK, thank you very much. I shall config my email client again to notice
> about it.

You should not use your email client to send patches, you should use
"git send-email":

http://wiki.qemu.org/Contribute/SubmitAPatch

Laurent