From: Michael Tokarev <mjt@tls.msk.ru>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qemu-stable@nongnu.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-9p: use accessor to get thread_pool
Date: Sun, 20 Dec 2015 14:26:33 +0300 [thread overview]
Message-ID: <56769069.6040105@msgid.tls.msk.ru> (raw)
In-Reply-To: <20151220111608.6664.85476.stgit@bahia.local>
20.12.2015 14:19, Greg Kurz wrote:
> The aio_context_new() function does not allocate a thread pool. This is
> deferred to the first call to the aio_get_thread_pool() accessor. It is
> hence forbidden to access the thread_pool field directly, as it may be
> NULL. The accessor *must* be used always.
>
> Fixes: ebac1202c95a4f1b76b6ef3f0f63926fa76e753e
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Tested-by: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-stable@nongnu.org
> Michael,
>
> I did not have time to reproduce the issue, and therefore to
> effectively test this patch fixes it. Maybe you can do it ?
Yes, it effectively fixes the issue.
Meanwhile I looked at the whole thing with how thread pools are
allocated, and now can add my R-b too.
Thank you!
/mjt
prev parent reply other threads:[~2015-12-20 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 11:19 [Qemu-devel] [PATCH] virtio-9p: use accessor to get thread_pool Greg Kurz
2015-12-20 11:26 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56769069.6040105@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).