From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com,
leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 2/5] igd-passthrough-i440FX: convert to realize()
Date: Sun, 20 Dec 2015 19:59:03 +0800 [thread overview]
Message-ID: <56769807.5010809@cn.fujitsu.com> (raw)
In-Reply-To: <87poy3wj4u.fsf@blackfin.pond.sub.org>
On 12/19/2015 05:18 AM, Markus Armbruster wrote:
> One short remark in addition to Eduardo's review.
>
> Eduardo Habkost <ehabkost@redhat.com> writes:
>
[...]
>>>
>>> config_fd = open(path, O_RDWR);
>>> if (config_fd < 0) {
>>> + error_setg(errp, "No such device");
>>> return -ENODEV;
>>> }
>
> Can we come up with nicer error messages?
>
Ok...will change the error msg to strerror(errno)
> [...]
>
>
> .
>
--
Yours Sincerely,
Cao Jin
next prev parent reply other threads:[~2015-12-20 11:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 11:03 [Qemu-devel] [PATCH 0/5] Convert to realize() Cao jin
2015-12-18 11:03 ` [Qemu-devel] [PATCH 1/5] SH PCI Host: convert " Cao jin
2015-12-18 17:59 ` Paolo Bonzini
2016-01-10 18:13 ` Michael Tokarev
2015-12-18 11:03 ` [Qemu-devel] [PATCH 2/5] igd-passthrough-i440FX: " Cao jin
2015-12-18 18:37 ` Eduardo Habkost
2015-12-18 21:18 ` Markus Armbruster
2015-12-20 11:59 ` Cao jin [this message]
2016-01-11 14:32 ` Markus Armbruster
2016-01-12 2:24 ` Cao jin
2015-12-20 11:56 ` Cao jin
2015-12-18 11:03 ` [Qemu-devel] [PATCH 3/5] PXB: " Cao jin
2015-12-18 18:01 ` Paolo Bonzini
2015-12-20 11:38 ` Cao jin
2015-12-21 10:39 ` Cao jin
2015-12-21 15:49 ` Paolo Bonzini
2015-12-22 3:58 ` Cao jin
2015-12-22 7:34 ` Marcel Apfelbaum
2015-12-22 9:16 ` Cao jin
2015-12-22 9:35 ` Marcel Apfelbaum
2015-12-22 9:52 ` Cao jin
2015-12-22 11:40 ` Cao jin
2015-12-20 10:22 ` Marcel Apfelbaum
2015-12-20 10:48 ` Cao jin
2015-12-20 11:21 ` Marcel Apfelbaum
2015-12-21 2:59 ` Cao jin
2015-12-21 10:08 ` Marcel Apfelbaum
2015-12-21 10:19 ` Cao jin
2015-12-18 11:03 ` [Qemu-devel] [PATCH 4/5] gt64120: " Cao jin
2015-12-18 17:59 ` Paolo Bonzini
2016-01-10 18:12 ` Michael Tokarev
2015-12-18 11:03 ` [Qemu-devel] [PATCH 5/5] xen-pvdevice: " Cao jin
2015-12-18 18:00 ` Paolo Bonzini
2015-12-21 5:52 ` Cao jin
2015-12-21 15:00 ` Stefano Stabellini
2015-12-21 15:15 ` Stefano Stabellini
2015-12-22 1:24 ` Cao jin
2015-12-22 2:40 ` Cao jin
2015-12-18 11:08 ` [Qemu-devel] [PATCH 0/5] Convert " Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56769807.5010809@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=leon.alrae@imgtec.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).