qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	 QEMU Developers <qemu-devel@nongnu.org>
Cc: Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH 0/5] docs/system: Document some arm board models
Date: Fri, 15 May 2020 10:03:01 +0200	[thread overview]
Message-ID: <567755c6-3bb1-b16e-af26-431dec4616ba@redhat.com> (raw)
In-Reply-To: <CAFEAcA_p1x6S10yswHgOkMd=KrxcTGh9TD47+k1LRKM0xy5x+Q@mail.gmail.com>

Hi Peter,

+Markus

On 5/14/20 3:28 PM, Peter Maydell wrote:
> Ping for review?

For the series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

However I'd rather see the board documentation in the source code, and 
extract it when building. It'd be harder to miss updating the 
documentation when modifying the code.

Another way (rather than using external program to extract from source 
code) can be to add a method/field to MachineClass, and once a build is 
finished, we could run 'qemu-system-arch -M gendoc' which go thru all 
machines and display the documentation properly formatted.

> 
> thanks
> -- PMM
> 
> On Thu, 7 May 2020 at 16:18, Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> This patchset adds (minimal) documentation of these Arm board models:
>>
>> vexpress-a15         ARM Versatile Express for Cortex-A15
>> vexpress-a9          ARM Versatile Express for Cortex-A9
>> mps2-an385           ARM MPS2 with AN385 FPGA image for Cortex-M35
>> mps2-an505           ARM MPS2 with AN505 FPGA image for Cortex-M33
>> mps2-an511           ARM MPS2 with AN511 DesignStart FPGA image for Cortex-M3
>> mps2-an521           ARM MPS2 with AN521 FPGA image for dual Cortex-M33
>> musca-a              ARM Musca-A board (dual Cortex-M33)
>> musca-b1             ARM Musca-B1 board (dual Cortex-M33)
>>
>> to the system emulator manual.
>>
>> Patches 1 and 2 are minor tidyup of the board table-of-contents
>> before we start adding new entries with patches 3-5.
>>
>> I'm aiming more for "at least note that the boards exist" than
>> "fully comprehensive" documentation here -- there are still another
>> 37 Arm board models with no documentation at all...
>>
>> thanks
>> -- PMM
>>
>> Peter Maydell (5):
>>    docs/system: Add 'Arm' to the Integrator/CP document title
>>    docs/system: Sort Arm board index into alphabetical order
>>    docs/system: Document Arm Versatile Express boards
>>    docs/system: Document the various MPS2 models
>>    docs/system: Document Musca boards
>>
>>   docs/system/arm/integratorcp.rst |  4 +--
>>   docs/system/arm/mps2.rst         | 29 +++++++++++++++
>>   docs/system/arm/musca.rst        | 31 +++++++++++++++++
>>   docs/system/arm/vexpress.rst     | 60 ++++++++++++++++++++++++++++++++
>>   docs/system/target-arm.rst       | 15 ++++----
>>   MAINTAINERS                      |  3 ++
>>   6 files changed, 134 insertions(+), 8 deletions(-)
>>   create mode 100644 docs/system/arm/mps2.rst
>>   create mode 100644 docs/system/arm/musca.rst
>>   create mode 100644 docs/system/arm/vexpress.rst
>>
>> --
>> 2.20.1
>>
> 



  reply	other threads:[~2020-05-15  8:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 15:18 [PATCH 0/5] docs/system: Document some arm board models Peter Maydell
2020-05-07 15:18 ` [PATCH 1/5] docs/system: Add 'Arm' to the Integrator/CP document title Peter Maydell
2020-05-14 13:54   ` Edgar E. Iglesias
2020-05-15  9:00   ` Alex Bennée
2020-05-07 15:18 ` [PATCH 2/5] docs/system: Sort Arm board index into alphabetical order Peter Maydell
2020-05-14 13:54   ` Edgar E. Iglesias
2020-05-15  9:41   ` Alex Bennée
2020-05-07 15:18 ` [PATCH 3/5] docs/system: Document Arm Versatile Express boards Peter Maydell
2020-05-14 13:55   ` Edgar E. Iglesias
2020-05-15  9:54   ` Alex Bennée
2020-05-07 15:18 ` [PATCH 4/5] docs/system: Document the various MPS2 models Peter Maydell
2020-05-14 13:56   ` Edgar E. Iglesias
2020-05-15  9:55   ` Alex Bennée
2020-05-07 15:18 ` [PATCH 5/5] docs/system: Document Musca boards Peter Maydell
2020-05-14 13:56   ` Edgar E. Iglesias
2020-05-15  7:56   ` Philippe Mathieu-Daudé
2020-05-15  8:48     ` Peter Maydell
2020-05-15  9:06       ` Philippe Mathieu-Daudé
2020-05-15  9:56   ` Alex Bennée
2020-05-14 13:28 ` [PATCH 0/5] docs/system: Document some arm board models Peter Maydell
2020-05-15  8:03   ` Philippe Mathieu-Daudé [this message]
2020-05-15  8:51     ` Peter Maydell
2020-05-15  9:05       ` Philippe Mathieu-Daudé
2020-05-15 10:23         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567755c6-3bb1-b16e-af26-431dec4616ba@redhat.com \
    --to=philmd@redhat.com \
    --cc=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).