From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB0Gc-0006nt-2I for qemu-devel@nongnu.org; Mon, 21 Dec 2015 08:12:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aB0GY-0002lh-1U for qemu-devel@nongnu.org; Mon, 21 Dec 2015 08:12:46 -0500 Message-ID: <5677FAA8.3050901@huawei.com> Date: Mon, 21 Dec 2015 21:12:08 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1449704528-289297-1-git-send-email-imammedo@redhat.com> <20151219203841.GC25389@redhat.com> <20151221140042.5a74f8c9@nial.brq.redhat.com> In-Reply-To: <20151221140042.5a74f8c9@nial.brq.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/74] pc: acpi: convert DSDT to AML API and drop ASL templates support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , "Michael S. Tsirkin" Cc: Peter Maydell , Eduardo Habkost , qemu-devel@nongnu.org, ARM ACPI Subsystem , Paolo Bonzini , Richard Henderson On 2015/12/21 21:00, Igor Mammedov wrote: > On Sat, 19 Dec 2015 22:38:41 +0200 > "Michael S. Tsirkin" wrote: > >> > On Thu, Dec 10, 2015 at 12:40:54AM +0100, Igor Mammedov wrote: >>> > > Due to huge size, CCing only cover letter instead of individual patches. >>> > > >>> > > Series consist of 2 parts the 1st part prefixed 'acpi:' adds necessary >>> > > AML API functions and the second part converts DSDT using existing and >>> > > new AML API. >>> > > >>> > > Series does exact byte by byte conversion and passes ACPI tables >>> > > 'make check' tests. >>> > > The conversion first moves common for PIIX4/Q35 parts, getting rid of *.dsl >>> > > includes and then converts PIIX4 and Q35 parts of DSDT. >>> > > >>> > > Diff-stat looks nice but actual code base is reduced by ~2000LOC >>> > > while the rest of 10000 removals is dropping precompiled AML >>> > > templates from tree. >>> > > >>> > > There are some AML parts that could be optimized/simplified and shared >>> > > between PIIX4/Q35/ARM but doing it will break exact match with original >>> > > tests, hence it's left out of the scope of this series. >>> > > >>> > > CC: "Michael S. Tsirkin" (supporter:ACPI/SMBIOS) >>> > > CC: Shannon Zhao (maintainer:ARM ACPI Subsystem) >>> > > CC: Peter Maydell (maintainer:ARM) >>> > > CC: Paolo Bonzini (maintainer:X86) >>> > > CC: Richard Henderson (maintainer:X86) >>> > > CC: Eduardo Habkost (maintainer:X86) >>> > > CC: qemu-arm@nongnu.org (open list:ARM ACPI Subsystem) >> > >> > I think this is a nice series, and I think we can live with the fact >> > make check warns in the middle. >> > >> > I sent some comments I'd like to see addressed. >> > >> > Main points >> > - one v2 patch seems garbled >> > - please don't create functions with tons of parameters >> > which just do if (a) on each of these internally. >> > instead, move common code into a small function that >> > can be reused without so many conditionals. >> > - I really dislike local variables starting with a_ for >> > no good reason. > Michael, > > Could you apply already reviewed AML API patches 1-24 > and push it to master early, pls? > +1 BTW, Below patches are already in master. [PATCH 15/74] acpi: support serialized method [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs > That will help to reduce collisions with other AML > patches on list and provide more complete API for others to use. > -- Shannon