From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB2QE-0003tm-HW for qemu-devel@nongnu.org; Mon, 21 Dec 2015 10:30:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aB2QB-0005yU-DC for qemu-devel@nongnu.org; Mon, 21 Dec 2015 10:30:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB2QB-0005yH-4n for qemu-devel@nongnu.org; Mon, 21 Dec 2015 10:30:47 -0500 References: <20151219212440.GC4287@var.home> From: Eric Blake Message-ID: <56781B20.2050405@redhat.com> Date: Mon, 21 Dec 2015 08:30:40 -0700 MIME-Version: 1.0 In-Reply-To: <20151219212440.GC4287@var.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sjx0IoS06XlOu2AJ3nSwb7lxeCNUmilXe" Subject: Re: [Qemu-devel] [PATCHv7 0/9] slirp: Adding IPv6 support to Qemu -net user mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Thibault , zhanghailiang Cc: Thomas Huth , Li Zhijian , Stefan Hajnoczi , Jason Wang , qemu-devel , Vasiliy Tolstov , peter.huangpeng@huawei.com, "Gonglei (Arei)" , Stefan Hajnoczi , "J. Kiszka" , Yang Hongyang , Dave Gilbert This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sjx0IoS06XlOu2AJ3nSwb7lxeCNUmilXe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/19/2015 02:24 PM, Samuel Thibault wrote: > Hello, meta-reply >=20 > This is another respin of IPv6 in Qemu -net user mode. >=20 > The following patches first make some refactoring to make current code = ready > for IPv6, and do not change the behavior. The actual IPv6 support will= then be > submitted as a separate patch series. >=20 > Difference with version 6 is: > - Use error_report instead of printing to stderr > - Drop extra parentheses > - Use nicer-looking sockaddr casts. >=20 > All of this has been reviewed by Thomas Huth, thanks! It looks like you wrote your own cover letter, then supplied the git series in reply to your cover letter but with the git series still internally threaded. This resulted in the unusual reply tree of: 0/9 + 1/9 + 2/9 + 3/9 + ... + 9/9 and where clients that display trees based both on reply relationships and age would show: 0/9 + 1/9 + 2/9 | + Re: 2/9 + ... + 9/9 | + Re: 9/9 + Re: 1/9 That is, in your series, all of 2 through 9 were marked as children of 1, rather than a sibling of 1. The more typical flat threading looks lik= e: 0/9 + 1/9 + 2/9 + ... + 9/9 where replies to 1 are then threaded closer to the original: 0/9 + 1/9 | + Re: 1/9 + 2/9 | + Re: 2/9 + ... + 9/9 + Re: 9/9 You may want to look into using 'git format-patch --cover-letter'; easily done with 'git config format.coverLetter auto'. The git cover letter would include a diffstat that includes the names of all files touched by the series as well as relative sizing of the patch, which is helpful to users. Also, using git to produce the cover letter (producing all of 0 through 9 in one shot, with 1-9 all threaded as siblings to each other and children of 0), instead of producing the body with git (just 1 through 9, with 2-9 replying to 1) and then chaining that series to a hand-written cover letter, would solve the unusual threading. >=20 > Here is a summary of the patches: >=20 > [PATCH 1/9] slirp: goto bad in udp_input if sosendto fails > [PATCH 2/9] slirp: Generalizing and neutralizing ARP code > [PATCH 3/9] slirp: Adding address family switch for incoming frames > [PATCH 4/9] slirp: Make Socket structure IPv6 compatible > [PATCH 5/9] slirp: Factorizing address translation > [PATCH 6/9] slirp: Factorizing and cleaning solookup() > [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic > [PATCH 8/9] slirp: Make udp_attach IPv6 compatible > [PATCH 9/9] slirp: Adding family argument to tcp_fconnect() >=20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sjx0IoS06XlOu2AJ3nSwb7lxeCNUmilXe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeBsgAAoJEKeha0olJ0NqIAgH/iQuBzPLbMoPChf7GGg0Dapo NxEbF80OKsT3f/FJx9E1yp20VD6B2EoTJR3JXRh8XAMZaJ+9fDrQHgasmZmTR4zI GJYDzEqcG/FbFRQ5t9MIuUChjHQlNiSE9qM8EZK3H9duCSZhSMf2+cGT4ReBKMcX U49i2kgRhBAnlapjuXB/LbA4QxXVJtK2cWfkuWy4XxLQKqf3xEHoer88tWwTC+QI tm/N9cwZo7VB69r3S7vXveXY/1ZZEtLmonj7LRTkkCGYnw4ZTK+6IPn37a+kU09l lzYG9Z2fcRXrn7br/gioKs55mpXDyJUR6IiT9ECjEzLUEcd7KYUSSLrJisPvLhQ= =pm7/ -----END PGP SIGNATURE----- --sjx0IoS06XlOu2AJ3nSwb7lxeCNUmilXe--