From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB3BQ-0000FB-TX for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:19:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aB3BN-0001rv-MG for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:19:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB3BN-0001rr-Gb for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:19:33 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 29D30693C2 for ; Mon, 21 Dec 2015 16:19:33 +0000 (UTC) References: <1450714014-16849-1-git-send-email-berrange@redhat.com> <1450714014-16849-2-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <56782662.9000502@redhat.com> Date: Mon, 21 Dec 2015 09:18:42 -0700 MIME-Version: 1.0 In-Reply-To: <1450714014-16849-2-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7SELdFLQnr0V63JSrJmT9p7M0E44nFpCH" Subject: Re: [Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key, block & IV lens List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7SELdFLQnr0V63JSrJmT9p7M0E44nFpCH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > Adds new methods to allow querying the length of the cipher > key, block size and initialization vectors. In the subject line, I read 'lens' as a synonym for 'viewports', not 'lengths'. But I don't know if avoiding the abbreviation is worth it, because the subject line is already bordering on long. Maybe avoiding it altogether is easier? crypto: Add additional query accessors >=20 > Signed-off-by: Daniel P. Berrange > --- > crypto/cipher.c | 48 ++++++++++++++++++++++++++++++++++++++= ++++++++ > include/crypto/cipher.h | 37 +++++++++++++++++++++++++++++++++++ > tests/test-crypto-cipher.c | 10 ++++++++++ > 3 files changed, 95 insertions(+) >=20 But no problems with the actual patch, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7SELdFLQnr0V63JSrJmT9p7M0E44nFpCH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeCZiAAoJEKeha0olJ0NqQPUH/1x2/vdMKpVDdQzhglhHLa4F srRpOOgpHILwDd5wLKz2SXr077+Mo7XODm8NNgwTTFDlGq9e8JwpKDUKXOH4fRnY mjup6j+ZyQU+4ya9IouYgmwqg5lzH946u559fjtBe5XHqm+RUd2fUTPCLU+FUDxn rBUDFsh9HZ44QuvzN6X1dIXmlx/nZNjDWj7vcsTbRo2aYoybdx60NFxAMfeI+auF T58fxbcNM7s14UML4WuhDjgokPzdkGaKVHAq2/HnPUYlo7tuIwtShcdWjUBRhiEv +vc0S8OZRkhQ/GwZjEeCeeSMKjvgo6lPChS2pQ7w69k9CojutQWAEhB1KxLLndI= =yPwO -----END PGP SIGNATURE----- --7SELdFLQnr0V63JSrJmT9p7M0E44nFpCH--