Re: [Qemu-devel] [PATCH 2/6] crypto: add ability to query hash digest len

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On 12/21/2015 09:06 AM, Daniel P. Berrange wrote:
> Add a qcrypto_hash_digest_len() method which allows querying of
> the raw digest size for a given hash algorithm.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  crypto/hash.c            | 15 +++++++++++++++
>  include/crypto/hash.h    | 11 +++++++++++
>  tests/test-crypto-hash.c |  5 +++++
>  3 files changed, 31 insertions(+)
> 

> +++ b/tests/test-crypto-hash.c
> @@ -163,6 +163,11 @@ static void test_hash_digest(void)
>      for (i = 0; i < G_N_ELEMENTS(expected_outputs) ; i++) {
>          int ret;
>          char *digest;
> +        size_t digestsize;
> +
> +        digestsize = qcrypto_hash_digest_len(i);
> +
> +        g_assert((digestsize * 2) == strlen(expected_outputs[i]));

g_assert_cmpint() might be better here. But that's minor.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]