From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB3LE-0000Tx-S5 for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:29:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aB3LB-0004vN-NV for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:29:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB3LB-0004v9-IZ for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:29:41 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 428143B758 for ; Mon, 21 Dec 2015 16:29:41 +0000 (UTC) References: <1450714014-16849-1-git-send-email-berrange@redhat.com> <1450714014-16849-5-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <567828F4.7000907@redhat.com> Date: Mon, 21 Dec 2015 09:29:40 -0700 MIME-Version: 1.0 In-Reply-To: <1450714014-16849-5-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DBEfAsGjfteE75bG131dCHtGwC0FQQIVA" Subject: Re: [Qemu-devel] [PATCH 4/6] crypto: move QCryptoCipherAlgorithm/Mode enum definitions into QAPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DBEfAsGjfteE75bG131dCHtGwC0FQQIVA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > The QCryptoCipherAlgorithm and QCryptoCipherMode enums are > defined in the crypto/cipher.h header. In the future some > QAPI types will want to reference the hash enums, so move > the enum definition into QAPI too. >=20 > Signed-off-by: Daniel P. Berrange > --- > crypto/cipher.c | 8 ++++---- > include/crypto/cipher.h | 17 ++--------------- > qapi/crypto.json | 30 ++++++++++++++++++++++++++++++ > 3 files changed, 36 insertions(+), 19 deletions(-) >=20 > diff --git a/crypto/cipher.c b/crypto/cipher.c > index d02bb32..e92d49a 100644 > --- a/crypto/cipher.c > +++ b/crypto/cipher.c > @@ -21,21 +21,21 @@ > #include "crypto/cipher.h" > =20 > =20 > -static size_t alg_key_len[QCRYPTO_CIPHER_ALG_LAST] =3D { > +static size_t alg_key_len[QCRYPTO_CIPHER_ALG_MAX] =3D { Will need rebasing, now that commit 7fb1cf1 has landed and renamed it QCRYPTO_CIPHER_ALG__MAX. Otherwise looks fine. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DBEfAsGjfteE75bG131dCHtGwC0FQQIVA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeCj0AAoJEKeha0olJ0NqwjkIAI1JA3N3I13XfAGvax2ONLPc zqJPNweIdgodYtzUCggqwqEB2zc9hfZypPbAZ7wE3PMCHe/GpRzIM8Dwbh2fovAc Dl4aa2fy7bGTFwwsKhhmw/dgl/sjENaZ6dy46ab1oVsnXo0dw4C1GwtJN7YJ8phg zFyiJ3Y3YaIK/dnYF5NimyJy1DD0h8x7FbVIrL93GMrmJQQtlXcBToQvRmv6ecHV 9emBJYTryXoC97qTRVrjZIZ733E0dp/oibmH2tVDPwttqf7ygeZmSac+nACnielG JMX5NbXFQOEmjEWvfgys4e4eAaivHS7x2hS+Ur0i1yc8aG8SWUwc8Xqz/5Hr8ow= =rFWO -----END PGP SIGNATURE----- --DBEfAsGjfteE75bG131dCHtGwC0FQQIVA--