From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBO5y-0005OC-2O for qemu-devel@nongnu.org; Tue, 22 Dec 2015 09:39:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBO5x-0006KF-7N for qemu-devel@nongnu.org; Tue, 22 Dec 2015 09:39:22 -0500 References: <1450779107-26765-1-git-send-email-famz@redhat.com> From: John Snow Message-ID: <56796093.4080407@redhat.com> Date: Tue, 22 Dec 2015 09:39:15 -0500 MIME-Version: 1.0 In-Reply-To: <1450779107-26765-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block/qapi: Clear err for further error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , qemu-block@nongnu.org, mreitz@redhat.com On 12/22/2015 05:11 AM, Fam Zheng wrote: > Since a5002d5 (block/qapi: allow best-effort query) we don't return at > this error, however err must be cleared before passing to > bdrv_query_snapshot_info_list below, as required by error API. > > Signed-off-by: Fam Zheng > --- > block/qapi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/qapi.c b/block/qapi.c > index fecac25..58d3975 100644 > --- a/block/qapi.c > +++ b/block/qapi.c > @@ -250,6 +250,7 @@ void bdrv_query_image_info(BlockDriverState *bs, > g_free(backing_filename2); > backing_filename2 = NULL; > error_free(err); > + err = NULL; > } > > /* Always report the full_backing_filename if present, even if it's the > Sorry Markus, I've failed you. Reviewed-by: John Snow