Re: [Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append'

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

On 12/22/2015 02:49 AM, Denis V. Lunev wrote:
>     commit 31e38a22a0c5a25646f966f001e1f5513d5a186d
>     Author: Olga Krishtal <okrishtal@virtuozzo.com>
>     Date:   Fri Dec 4 09:42:04 2015 +0300
> 
>         qemu-char: append opt to stop truncation of serial file
> 
> has added the option to the runtime but does not added it to -help
> output. This blocks libvirt from using it.

In addition to Dan's comment about the dead sentence,


> +@option{append} specifies that QEMU must truncate the file on open.
> +@option{append} is optional, default value is off.

This is backwards.  It should read something more like:

@option{append} specifies that QEMU should append to the file. It
defaults to off, for truncating the file instead of appending.

Or maybe:

@option{append} controls whether QEMU truncates the file (default if
omitted, or if specified as off), or appends to the file (specified as on).

Check if there are other similar wordings to borrow from.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]