From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBPFX-0007NK-EQ for qemu-devel@nongnu.org; Tue, 22 Dec 2015 10:53:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBPFU-0007eY-7l for qemu-devel@nongnu.org; Tue, 22 Dec 2015 10:53:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBPFU-0007eU-0w for qemu-devel@nongnu.org; Tue, 22 Dec 2015 10:53:16 -0500 References: <1450777749-14022-1-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <567971E0.4020603@redhat.com> Date: Tue, 22 Dec 2015 08:53:04 -0700 MIME-Version: 1.0 In-Reply-To: <1450777749-14022-1-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JhnWdAxHEUWAOFNm4hrc4EDdb1URjFaDe" Subject: Re: [Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Paolo Bonzini , Dmitry Mishin , qemu-devel@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JhnWdAxHEUWAOFNm4hrc4EDdb1URjFaDe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/22/2015 02:49 AM, Denis V. Lunev wrote: > commit 31e38a22a0c5a25646f966f001e1f5513d5a186d > Author: Olga Krishtal > Date: Fri Dec 4 09:42:04 2015 +0300 >=20 > qemu-char: append opt to stop truncation of serial file >=20 > has added the option to the runtime but does not added it to -help > output. This blocks libvirt from using it. In addition to Dan's comment about the dead sentence, > +@option{append} specifies that QEMU must truncate the file on open. > +@option{append} is optional, default value is off. This is backwards. It should read something more like: @option{append} specifies that QEMU should append to the file. It defaults to off, for truncating the file instead of appending. Or maybe: @option{append} controls whether QEMU truncates the file (default if omitted, or if specified as off), or appends to the file (specified as on= ). Check if there are other similar wordings to borrow from. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JhnWdAxHEUWAOFNm4hrc4EDdb1URjFaDe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeXHgAAoJEKeha0olJ0NqL4IH/jksBfDATVWTLL6eeRKlyInE 79Y9oTnmo6cAoyxshLEQ5iKhCS0rLoOKZvjLqlriab9hXdLtnT0b6jAZNC6YRM13 OkzSpzitf5RlgvGC4GVS04Ax6WhzaxTB43z5iQixINYXhQpHhXRCK53jlww3zitA vZEPAR2o5YrQeVppF3M7E07hhwKJg5d3jfC8Epc06aNrHcvy3BdERJb2p723JPwV ibhhjGvvuHElO9AdlrLW5oramTlTaR4UUQcqR0cEI9ZzMtVJT7PoGYJnS3jtYkqQ YNPge85PRY1bThg2knBfPNuIP84qODnKZkWYXKYtYvTVQpa6oIEvElKzCj+8jz0= =HUa0 -----END PGP SIGNATURE----- --JhnWdAxHEUWAOFNm4hrc4EDdb1URjFaDe--