From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBPOA-0005qL-HX for qemu-devel@nongnu.org; Tue, 22 Dec 2015 11:02:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBPO1-00023i-5t for qemu-devel@nongnu.org; Tue, 22 Dec 2015 11:02:14 -0500 References: <1450782389-17326-1-git-send-email-berrange@redhat.com> <1450782389-17326-2-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <567973F6.9040704@redhat.com> Date: Tue, 22 Dec 2015 09:01:58 -0700 MIME-Version: 1.0 In-Reply-To: <1450782389-17326-2-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1wFcXehUgNQqKirDDN0X7xfC9JRgN9fLM" Subject: Re: [Qemu-devel] [PATCH 1/7] qom: add user_creatable_add & user_creatable_del methods List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Markus Armbruster , qemu-block@nongnu.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1wFcXehUgNQqKirDDN0X7xfC9JRgN9fLM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/22/2015 04:06 AM, Daniel P. Berrange wrote: > The QMP monitor code has two helper methods object_add > and qmp_object_del that are called from several places > in the code (QMP, HMP and main emulator startup). >=20 > We soon need to use this code from qemu-img, qemu-io > and qemu-nbd too, but don't want those to depend on > the monitor. >=20 > To avoid this, move object_add to user_creatable_add > an qmp_object_del to user_creatable_del, to the > object_interfaces.c file where they can be easily > shared with all users of QOM >=20 > Signed-off-by: Daniel P. Berrange > --- > hmp.c | 11 ++++-- > include/monitor/monitor.h | 3 -- > include/qom/object_interfaces.h | 31 +++++++++++++++++ > qmp.c | 75 ++++-----------------------------= ------- > qom/object_interfaces.c | 76 +++++++++++++++++++++++++++++++++= ++++++++ > vl.c | 8 +++-- > 6 files changed, 127 insertions(+), 77 deletions(-) Looks like fairly straightforward code motion. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1wFcXehUgNQqKirDDN0X7xfC9JRgN9fLM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeXP2AAoJEKeha0olJ0NqWKwIAJhaF2P2csawc51PcA0HIbPZ McpubizSgkxKwAPjM2kqPfRmtLtF0iDKU6DaNNiji/jd37GWTUWY13fAzM9qBAeC ZTSQLli6dRvRi1C4WSud3JEJeUsu2OJEvnIJZy7kSd1SgSGs1uXTmqwYYjnGMyaH EFfj4SPaPUG/dKYZ/ZnnAqzna65GokiYOvVsqXfwn688/kaijdI+5O/Rriv4WK3W uXdRJnsYo7DKeCC4lPVHtaQfzDlUVymaNW7mVZasHxMN/6Yg8LXRc28lVhhkbhGT 1jwpQOQrbwlDHZg/OFr1ifHXr3+nk70ThW4RvwHcnRb+zeqmknhy7p4+JiRb8Qo= =Uvl/ -----END PGP SIGNATURE----- --1wFcXehUgNQqKirDDN0X7xfC9JRgN9fLM--