From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBRSQ-0001cn-L4 for qemu-devel@nongnu.org; Tue, 22 Dec 2015 13:14:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBRSN-0004Np-FQ for qemu-devel@nongnu.org; Tue, 22 Dec 2015 13:14:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBRSN-0004NM-9e for qemu-devel@nongnu.org; Tue, 22 Dec 2015 13:14:43 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 2A45F1308 for ; Tue, 22 Dec 2015 18:14:42 +0000 (UTC) References: <1450715016-18230-1-git-send-email-berrange@redhat.com> <1450715016-18230-2-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <56799311.5040508@redhat.com> Date: Tue, 22 Dec 2015 11:14:41 -0700 MIME-Version: 1.0 In-Reply-To: <1450715016-18230-2-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MnrgMBsR3M184r16SLb2R0cG79LLCd8tQ" Subject: Re: [Qemu-devel] [PATCH 1/2] io: fix setting of QIO_CHANNEL_FEATURE_FD_PASS on server connections List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MnrgMBsR3M184r16SLb2R0cG79LLCd8tQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/21/2015 09:23 AM, Daniel P. Berrange wrote: > The QIO_CHANNEL_FEATURE_FD_PASS feature flag is set in the > qio_channel_socket_set_fd() method, however, this only deals > with client side connections. >=20 > To ensure server side connections also have the feature flag > set, we must set it in qio_channel_socket_accept() too. >=20 > Signed-off-by: Daniel P. Berrange > --- > io/channel-socket.c | 10 ++++++++-- > tests/test-io-channel-socket.c | 29 +++++++++++++++++++++++++---- > 2 files changed, 33 insertions(+), 6 deletions(-) >=20 > diff --git a/io/channel-socket.c b/io/channel-socket.c > index 90b3c73..eed2ff5 100644 > --- a/io/channel-socket.c > +++ b/io/channel-socket.c > @@ -352,13 +352,19 @@ qio_channel_socket_accept(QIOChannelSocket *ioc, > goto error; > } > =20 > - if (getsockname(cioc->fd, (struct sockaddr *)&ioc->localAddr, > - &ioc->localAddrLen) < 0) { > + if (getsockname(cioc->fd, (struct sockaddr *)&cioc->localAddr, > + &cioc->localAddrLen) < 0) { Looks like a typo fix while at it. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MnrgMBsR3M184r16SLb2R0cG79LLCd8tQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeZMRAAoJEKeha0olJ0NqFF4H/RnrU2bJNElMP/Arz//IFunb +GgwlcCIMd8q+/PsSIJ+0Km2JGEr3Vs1B78cY9l8nNluvXYinrxyIQ1rNVnGTvC/ Chkhi5x4oMWzT2OpvM6W88/TU+aGXvXhagvEMJC8GM6jb65PYHKcznUlFuCmX4Ig srsGxFvhTqsm7bjtJpawB+iTnc8TtpGaKrbz1YZ8rpU1rBJ8pNFCr/RJeG8a8pX/ ZjhWYhgrwd42R2FzyfteU/1YxXlHjPEOodu63xHTev+2sLNE0RNRfUHWmJuspe+h fPiSp6lnQjXh5nduBm2obZR/eoj5Nx1WBago2HWl2EGSCsDi0lHtpB0oKcFUHeI= =TqFz -----END PGP SIGNATURE----- --MnrgMBsR3M184r16SLb2R0cG79LLCd8tQ--