From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBTQM-00063Y-14 for qemu-devel@nongnu.org; Tue, 22 Dec 2015 15:20:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBTQL-0007hD-2r for qemu-devel@nongnu.org; Tue, 22 Dec 2015 15:20:45 -0500 References: <1450802786-20893-1-git-send-email-kwolf@redhat.com> <1450802786-20893-2-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5679B08B.7090608@redhat.com> Date: Tue, 22 Dec 2015 13:20:27 -0700 MIME-Version: 1.0 In-Reply-To: <1450802786-20893-2-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uR0LGUatlETHmqFVTJNvq6V6aAktx0Mj0" Subject: Re: [Qemu-devel] [PATCH 01/10] qcow2: Write feature table only for v3 images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uR0LGUatlETHmqFVTJNvq6V6aAktx0Mj0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/22/2015 09:46 AM, Kevin Wolf wrote: > Version 2 images don't have feature bits, so writing a feature table to= > those images is kind of pointless. Fortunately, it is also harmless; even the v2 spec allowed for unknown extension headers. >=20 > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 48 ++++++++++++++++++++++++--------------= -------- > tests/qemu-iotests/031.out | 12 +----------- > tests/qemu-iotests/061.out | 15 --------------- > 3 files changed, 26 insertions(+), 49 deletions(-) >=20 Reviewed-by: Eric Blake Did you test that amend'ing an image from v2 to v3 adds the table, and downgrading from v3 to v2 drops the table? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uR0LGUatlETHmqFVTJNvq6V6aAktx0Mj0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWebCLAAoJEKeha0olJ0NqQrEH/1w8uml7Qm2F8D7H0pQRuVoq O14JvTcxVD/GwVzZSIAXrsPxQ5V90L0oPpe3w9yU+DkNKn0nBoW5f4x6u+Z7CV8M vCGCoqVdFQ1/EXqfzmgsLFv5Mq4AYlDNpy1jHlgx6yFHWgereiHSW1MEAw+V1r4c b3LA8YU9Gb2jMpeI3ck2xaH6THzbEr9nnm6H4ZCydxPxPdkMxrMNLJvMPjzf7SMR jIVYKNUVZLFMFJMlvRIMf5Rtnv7hDoTKGtmzVQjUhUUxPkh504B8HUKaijtu4NGz ssd/hRwPvJ9baSZq8nbu6ZniNeg04w8jq1DCB+1Y9SQjCvIyKhEDE4KWPERBJPA= =5ER4 -----END PGP SIGNATURE----- --uR0LGUatlETHmqFVTJNvq6V6aAktx0Mj0--