From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54505) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBTUe-0007XN-DK for qemu-devel@nongnu.org; Tue, 22 Dec 2015 15:25:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBTUd-0000IT-FH for qemu-devel@nongnu.org; Tue, 22 Dec 2015 15:25:12 -0500 References: <1450802786-20893-1-git-send-email-kwolf@redhat.com> <1450802786-20893-3-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5679B1A0.7010903@redhat.com> Date: Tue, 22 Dec 2015 13:25:04 -0700 MIME-Version: 1.0 In-Reply-To: <1450802786-20893-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TXphpXXwbFoPJx3wqoCWlHJa3O7InQHVU" Subject: Re: [Qemu-devel] [PATCH 02/10] qcow2: Write full header on image creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TXphpXXwbFoPJx3wqoCWlHJa3O7InQHVU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/22/2015 09:46 AM, Kevin Wolf wrote: > When creating a qcow2 image, we didn't necessarily call > qcow2_update_header(), but could end up with the basic header that > qcow2_create2() created manually. One thing that this basic header > lacks is the feature table. Let's make sure that it's always present. Aha, this helps answer my question on 1/10. >=20 > This requires a few updates to test cases as well. >=20 > Signed-off-by: Kevin Wolf > --- Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TXphpXXwbFoPJx3wqoCWlHJa3O7InQHVU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWebGgAAoJEKeha0olJ0NqvBIH/RH2ADQwFfE6lQiTvAlh1IZl qMn1oNnZZaYQMJY7L49WI0NAeoZjifpo8K2ZNaXui3ywjD0RCnTyGUzPYFyH+go2 rTTa0Da3tn10C93Ze7K5LyBVH5oHNtJNDQuA+1RxhEQTnSr0aobZX+8dE1HhJKld aX9hEJRYLi2HcGovwxtVFynxroMXSFyAOzaDeIAdu8rlWQeHeHwxDPoL4El3IWt9 M2LSlxArm6daF9CnDhYGDbgcpqK9F24uzlxjL4EDgPB5jNG3H7Za74/+SPCi74FY JpnAcSrBOxkaat1kpZnqgPK+7Ae+/EUvY9VdnBrngwVZqUK/RSxEvsBVE09KArg= =708f -----END PGP SIGNATURE----- --TXphpXXwbFoPJx3wqoCWlHJa3O7InQHVU--