From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBTX4-0000Sz-5z for qemu-devel@nongnu.org; Tue, 22 Dec 2015 15:27:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBTX3-0000v6-7G for qemu-devel@nongnu.org; Tue, 22 Dec 2015 15:27:42 -0500 References: <1450802786-20893-1-git-send-email-kwolf@redhat.com> <1450802786-20893-4-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5679B236.6000901@redhat.com> Date: Tue, 22 Dec 2015 13:27:34 -0700 MIME-Version: 1.0 In-Reply-To: <1450802786-20893-4-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Wh3Qjv0XiJ11esATSJtpgcXAbRXAjWe10" Subject: Re: [Qemu-devel] [PATCH 03/10] block: Assert no write requests under BDRV_O_INCOMING List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Wh3Qjv0XiJ11esATSJtpgcXAbRXAjWe10 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/22/2015 09:46 AM, Kevin Wolf wrote: > As long as BDRV_O_INCOMING is set, the image file is only opened so we > have a file descriptor for it. We're definitely not supposed to modify > the image, it's still owned by the migration source. >=20 > Signed-off-by: Kevin Wolf > --- > block/io.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 Reviewed-by: Eric Blake Based on the other thread going on, we may actually be able to hit this assertion due to a latent bug: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01126.html and maybe this assert will help us get a better stack trace to pinpoint the culprit? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Wh3Qjv0XiJ11esATSJtpgcXAbRXAjWe10 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWebI2AAoJEKeha0olJ0NqGOUIAIozPJCtGOFrl/RM8raBospy rRYUEeAXYjEb4kkQNAfZbrRxcWakq4av7p18lFjujpbVYWoDkWM7bFZj2a/V2cdD h0Un5h5NZgQM5X6iHWWEeEV1hknJMQdkntPcknDVHElXdwT4qPiI6JU4lrM8clAM tdN5D+ShkXRoQLZMmvSe2O2xXcULRfavuEwLno5kELvkqF4QkwvVj15l+e9cxLvJ LHMAb7Gpwo8EvVmruLVB3Erk5P9bcDbvKOe1+2luhrsQmqQSEUE93Y4K8UgIEGQ2 pQLSYsyzSXsy2PQn2jJv6Dgvni2rV4msiS1bv7JMNLgtIPBPfPIboLZuxUewm74= =satv -----END PGP SIGNATURE----- --Wh3Qjv0XiJ11esATSJtpgcXAbRXAjWe10--