From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBUPs-00009p-Nk for qemu-devel@nongnu.org; Tue, 22 Dec 2015 16:24:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBUPr-0004fX-Tr for qemu-devel@nongnu.org; Tue, 22 Dec 2015 16:24:20 -0500 References: <1450802786-20893-1-git-send-email-kwolf@redhat.com> <1450802786-20893-10-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5679BF7B.5090206@redhat.com> Date: Tue, 22 Dec 2015 14:24:11 -0700 MIME-Version: 1.0 In-Reply-To: <1450802786-20893-10-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ds01Om6jitlMcO0IikI0oSSgAS6taESQ4" Subject: Re: [Qemu-devel] [PATCH 09/10] qcow2: Make image inaccessible after failed qcow2_invalidate_cache() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ds01Om6jitlMcO0IikI0oSSgAS6taESQ4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/22/2015 09:46 AM, Kevin Wolf wrote: > If qcow2_invalidate_cache() fails, we are in a state where qcow2_close(= ) > has already been completed, but the image hasn't been reopened yet. > Calling into any qcow2 function for an image in this state will cause > crashes. >=20 > The real solution would be to get rid of the close/open pair and instea= d > do an atomic reset of the involved data structures, but this isn't > trivial, so let's just make the image inaccessible for now. >=20 > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 3 +++ > 1 file changed, 3 insertions(+) Band-aids are better than nothing. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ds01Om6jitlMcO0IikI0oSSgAS6taESQ4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeb97AAoJEKeha0olJ0NqwDAH/3aCsy+zxni/DQXPYq3BUaoB 9E7uqOqvFriGBI9TkbUiqfrRDdqaM+xvjT4U0BgBi7QMHe8eGSz9t/I8mCk5Zbux bG8PO0QKifQqE9VZ7JX94YgPecMXnpr4J2cvMrcUl7rUbbsAfbAfYRdrh+qw1C/D DHHg6aKDQrjZqsHuMwca6EGKvON7Yojx14tZj9TFQSnv5Y/UFXpSnB5S8gI2feP5 EOmggkBV3O3JScDLvWHXHwqd9m4Fo0AsYTamozHOL51V0J0g4s0HIY00rfTH5JRY lgUblqWYa/Zvy91ZzyIy7FJiMI4hTrp7EPmBqlZ8QdcGMd7vMg/R+bWwtkWrplg= =getY -----END PGP SIGNATURE----- --ds01Om6jitlMcO0IikI0oSSgAS6taESQ4--