From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBnNO-0005dq-OU for qemu-devel@nongnu.org; Wed, 23 Dec 2015 12:39:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBnNN-0008Pa-Qb for qemu-devel@nongnu.org; Wed, 23 Dec 2015 12:39:02 -0500 References: <1450890682-13600-1-git-send-email-berrange@redhat.com> <1450890682-13600-9-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <567ADC27.3050207@redhat.com> Date: Wed, 23 Dec 2015 10:38:47 -0700 MIME-Version: 1.0 In-Reply-To: <1450890682-13600-9-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JE7nkctTC17AE7KR4MHbIVSOB80VbIqW5" Subject: Re: [Qemu-devel] [PATCH v2 08/10] qemu-nbd: don't overlap long option values with short options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Markus Armbruster , qemu-block@nongnu.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JE7nkctTC17AE7KR4MHbIVSOB80VbIqW5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/23/2015 10:11 AM, Daniel P. Berrange wrote: > When defining values for long options, the normal practice is > to start numbering from 256, to avoid overlap with the range > of valid values for short options. >=20 > Signed-off-by: Daniel P. Berrange > --- > qemu-nbd.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake >=20 > diff --git a/qemu-nbd.c b/qemu-nbd.c > index 02fdcf1..9898e22 100644 > --- a/qemu-nbd.c > +++ b/qemu-nbd.c > @@ -44,12 +44,12 @@ > #include > =20 > #define SOCKET_PATH "/var/lock/qemu-nbd-%s" > -#define QEMU_NBD_OPT_CACHE 1 > -#define QEMU_NBD_OPT_AIO 2 > -#define QEMU_NBD_OPT_DISCARD 3 > -#define QEMU_NBD_OPT_DETECT_ZEROES 4 > -#define QEMU_NBD_OPT_OBJECT 5 > -#define QEMU_NBD_OPT_IMAGE_OPTS 6 > +#define QEMU_NBD_OPT_CACHE 256 > +#define QEMU_NBD_OPT_AIO 257 > +#define QEMU_NBD_OPT_DISCARD 258 > +#define QEMU_NBD_OPT_DETECT_ZEROES 259 > +#define QEMU_NBD_OPT_OBJECT 260 > +#define QEMU_NBD_OPT_IMAGE_OPTS 261 > =20 > static NBDExport *exp; > static int verbose; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JE7nkctTC17AE7KR4MHbIVSOB80VbIqW5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWetwnAAoJEKeha0olJ0Nq7AoH/1qk+ODajseSFzaf80/V60kp 1PVdouguvFRZqz0raM1DnKGXcrVnnJK8e56v7n78Qd3xi/mpeHlk00jHu/2PKIir CcD1pXsETGPCayo5G/UPbsgv2cp4TqDIVjujn2diV6J+tIH6dBIFcGwDTT/M4jO0 YHWNJdHe+OIsjk6DIO3YqKM+Dt+jEhsv9C6NucLB9xtiK1eqwWTvUZiLUhJeZZv6 SvZDobkgWmzkqXDV6bXNiOWZ6eldneNLgCz6+eIlC/BKfUGFNLQViwKe71+HMXmr 7Edzi1OJzxv9uczI9oOn7BM+uRT8m6DgK1K4YlH2/1fWN1Mc/BwwZIB93qAbQHI= =ZbFO -----END PGP SIGNATURE----- --JE7nkctTC17AE7KR4MHbIVSOB80VbIqW5--