From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBnOv-0007FQ-Ep for qemu-devel@nongnu.org; Wed, 23 Dec 2015 12:40:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBnOu-0000Sd-K2 for qemu-devel@nongnu.org; Wed, 23 Dec 2015 12:40:37 -0500 References: <1450890682-13600-1-git-send-email-berrange@redhat.com> <1450890682-13600-10-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <567ADC8E.4020501@redhat.com> Date: Wed, 23 Dec 2015 10:40:30 -0700 MIME-Version: 1.0 In-Reply-To: <1450890682-13600-10-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="So8OTTbxVM6WOAD09mWexAkLWJn5WE4rm" Subject: Re: [Qemu-devel] [PATCH v2 09/10] qemu-nbd: use no_argument/required_argument constants List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Markus Armbruster , qemu-block@nongnu.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --So8OTTbxVM6WOAD09mWexAkLWJn5WE4rm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/23/2015 10:11 AM, Daniel P. Berrange wrote: > When declaring the 'struct option' array, use the standard > constants no_argument/required_argument, instead of magic > values 0 and 1. >=20 > Signed-off-by: Daniel P. Berrange > --- > qemu-nbd.c | 47 ++++++++++++++++++++++++----------------------- > 1 file changed, 24 insertions(+), 23 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --So8OTTbxVM6WOAD09mWexAkLWJn5WE4rm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWetyOAAoJEKeha0olJ0NqX0AH/Av0HwmDVsshW+vn58mISYAf pFSLRvKn5kmwXljD+19HHCbq87nOBvX8w/Y9hwypJUI01A1bNx5awUN0SazAVLu6 yzG62zQM58Vh5CAKBrzkK1v7S4NunHn3SFhS4RUL715+nou0entySytamCEmkrg4 KTeiKBq/ovJx4ZyS23klxhlhFIA+OmKk1x8kq3M1tLWzPH/KWp8DG4YXvo+YH95t dwemHmY1PL5HNijXpZmjLghVKaauUZsaJzwcnncKT+/yNyBMkjH9/I+zPXk9jdrJ xdHubOwepglRL2jNEQgdXGrmbP6TsyBspScCwLE4WSBXQHko1PBCJJJ6fvokOCw= =CZIt -----END PGP SIGNATURE----- --So8OTTbxVM6WOAD09mWexAkLWJn5WE4rm--