From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBnjm-0007k9-Q0 for qemu-devel@nongnu.org; Wed, 23 Dec 2015 13:02:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBnjh-0006VI-RO for qemu-devel@nongnu.org; Wed, 23 Dec 2015 13:02:10 -0500 Sender: Paolo Bonzini References: <1450782389-17326-1-git-send-email-berrange@redhat.com> <1450782389-17326-5-git-send-email-berrange@redhat.com> <56798075.50005@redhat.com> <20151222172401.GL10082@redhat.com> From: Paolo Bonzini Message-ID: <567AE199.5090605@redhat.com> Date: Wed, 23 Dec 2015 19:02:01 +0100 MIME-Version: 1.0 In-Reply-To: <20151222172401.GL10082@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/7] qemu-io: add support for --object command line arg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Eric Blake Cc: Kevin Wolf , =?UTF-8?Q?Andreas_F=c3=a4rber?= , qemu-devel@nongnu.org, qemu-block@nongnu.org, Markus Armbruster On 22/12/2015 18:24, Daniel P. Berrange wrote: > I was a little reluctant to move this 'object_create' method into the > qom/ code though, since I hate the idea of the legacy 'QemuOpts' data > anywhere near those nice new APIs. I guess I could perhaps just keep the > qemu_opts_to_qdict() call in the caller. I disagree with calling QemuOpts legacy, but I agree that this shouldn't be in qom/object_interfaces.c. However, it could be moved to a separate file in qom/. Paolo