From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aBnlM-00013D-A7
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 13:03:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aBnlH-0006tn-BK
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 13:03:48 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1450782389-17326-1-git-send-email-berrange@redhat.com>
	<1450782389-17326-8-git-send-email-berrange@redhat.com>
	<5679897C.7060003@redhat.com> <20151222174159.GM10082@redhat.com>
	<56798D5B.4040800@redhat.com> <20151222180755.GN10082@redhat.com>
	<56799213.6090506@redhat.com> <20151223165553.GR20028@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <567AE1F6.4090107@redhat.com>
Date: Wed, 23 Dec 2015 19:03:34 +0100
MIME-Version: 1.0
In-Reply-To: <20151223165553.GR20028@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a
 set of options args
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>, qemu-devel@nongnu.org, qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>



On 23/12/2015 17:55, Daniel P. Berrange wrote:
>>> > > A third option would be to keep using positional arguments, but
>>> > > add a '--source-opts' *boolean* flag to indicate how to interpret
>>> > > the positional arguments.  ie without --source-opts we use the
>>> > > historic syntax, but with --source-opts, we assume the full QemuOpts
>>> > > syntax.
>> > 
>> > Oh, nice compromise. It's relatively discoverable (grep --help output),
>> > preserves back-compat of old scripts, and offers the full power for
>> > clients that want the full power.
> I've implemented this now and it makes the patches soooo much simpler
> too, so an added win.

Hmm, looks like I'm a bit late, but here's another possibility: making
--source-options (aka -o) take an argument, and if you specify both
--source-options and the positional argument, the latter is added as a
"file" key.

This way you can do "qemu-img info --object secret... -o secret=foo
iscsi://foo/".

Paolo