Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

[Paolo Bonzini <pbonzini@redhat.com>]

On 22/12/2015 00:33, Peter Crosthwaite wrote:
>>> >>
>>> >> case 0x80..0x8c
>> >
>> > Woah! Is that standard C?
>> >
> Yes, its probably one of the more recent language standards though.
> QEMU does use to more modern features liberally.

It's actually "case 0x80 ... 0x8c:".

>> Notice that this file comes from Linux. I know it's not pretty, but
>> can we please keep it as-is, for comparison purposes? I'm not sure
>> there's much value in cleaning it up locally...
>
> It looks very autogenerated and seems pretty nasty on the repetition.
> 
> As implementers of the hardware, it is much rarer to need these
> repetitious defs than the software users on the other side. "Do
> something specific with CPU#3's Mbox#5" is going to appear in
> software, but hardware implementers generally don't have a choice to
> implement things specifically and it usually ends up being looped and
> the exploded defs are never used. If there are only a handful of
> genuinely single defs needed, can they be fished out?

I see your point and I'm definitely in favor of rewriting headers from
scratch when practical, but any cleanup made is a recipe for unwanted
changes and bugs, especially if the source is full of repetitions.

Paolo