From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBqfv-0000VD-TL for qemu-devel@nongnu.org; Wed, 23 Dec 2015 16:10:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBqfs-0004xn-IT for qemu-devel@nongnu.org; Wed, 23 Dec 2015 16:10:23 -0500 Received: from relay.parallels.com ([195.214.232.42]:38881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBqfs-0004xd-AK for qemu-devel@nongnu.org; Wed, 23 Dec 2015 16:10:20 -0500 References: <1449240275-26196-1-git-send-email-den@openvz.org> <566A9873.7050400@openvz.org> <5673A346.7080606@openvz.org> From: "Denis V. Lunev" Message-ID: <567B0DAF.8020701@openvz.org> Date: Thu, 24 Dec 2015 00:10:07 +0300 MIME-Version: 1.0 In-Reply-To: <5673A346.7080606@openvz.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 for 2.6 0/5] QMP wrappers for VM snapshot operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amit Shah , Markus Armbruster , qemu-devel@nongnu.org, quintela@redhat.com On 12/18/2015 09:10 AM, Denis V. Lunev wrote: > On 12/11/2015 12:33 PM, Denis V. Lunev wrote: >> On 12/04/2015 05:44 PM, Denis V. Lunev wrote: >>> EFI based VM with pflash storage for NVRAM could not be snapshoted as >>> libvirt configures storage as 'raw' and writable. OK, this is a libvirt >>> problem. >>> >>> Another problem is that libvirt can not detect this failure at all >>> as it uses HMP for this operation. This create snapshot/delete snapshot >>> sequence passes silently. >>> >>> The patchset adds QMP wrappers for the purpose. >>> >>> Signed-off-by: "Denis V. Lunev" >>> CC: Juan Quintela >>> CC: Amit Shah >>> CC: Markus Armbruster >>> CC: Eric Blake >>> >>> Changes from v1: >>> - cosmetic fixes suggested by Markus. I pray I have added all of >>> them :) >>> - patch 5 is rewritten completely. Original one was deadbeaf >>> >>> Denis V. Lunev (5): >>> migration: split hmp_savevm to do_savevm and hmp_savevm wrapper >>> qmp: create qmp_savevm command >>> qmp: create qmp_delvm command >>> migration: improve error reporting for hmp_loadvm >>> qmp: create QMP implementation of loadvm command >>> >>> include/sysemu/sysemu.h | 2 +- >>> migration/savevm.c | 100 >>> +++++++++++++++++++++++++++++++----------------- >>> monitor.c | 7 +++- >>> qapi-schema.json | 39 +++++++++++++++++++ >>> qmp-commands.hx | 71 ++++++++++++++++++++++++++++++++++ >>> vl.c | 5 ++- >>> 6 files changed, 185 insertions(+), 39 deletions(-) >>> >> ping > ping v2 guys?