From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBsrP-0004iV-GF for qemu-devel@nongnu.org; Wed, 23 Dec 2015 18:30:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBsrO-0002N6-M8 for qemu-devel@nongnu.org; Wed, 23 Dec 2015 18:30:23 -0500 References: <1450779107-26765-1-git-send-email-famz@redhat.com> <56796093.4080407@redhat.com> From: Max Reitz Message-ID: <567B2E85.1000009@redhat.com> Date: Thu, 24 Dec 2015 00:30:13 +0100 MIME-Version: 1.0 In-Reply-To: <56796093.4080407@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PCpETbDiSV3MAXwWliNlGxO5EoCUn8Ohl" Subject: Re: [Qemu-devel] [PATCH] block/qapi: Clear err for further error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PCpETbDiSV3MAXwWliNlGxO5EoCUn8Ohl Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 22.12.2015 15:39, John Snow wrote: >=20 >=20 > On 12/22/2015 05:11 AM, Fam Zheng wrote: >> Since a5002d5 (block/qapi: allow best-effort query) we don't return at= >> this error, however err must be cleared before passing to >> bdrv_query_snapshot_info_list below, as required by error API. >> >> Signed-off-by: Fam Zheng >> --- >> block/qapi.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/block/qapi.c b/block/qapi.c >> index fecac25..58d3975 100644 >> --- a/block/qapi.c >> +++ b/block/qapi.c >> @@ -250,6 +250,7 @@ void bdrv_query_image_info(BlockDriverState *bs, >> g_free(backing_filename2); >> backing_filename2 =3D NULL; >> error_free(err); >> + err =3D NULL; >> } >> =20 >> /* Always report the full_backing_filename if present, even i= f it's the >> >=20 > Sorry Markus, I've failed you. >=20 > Reviewed-by: John Snow As did I by giving an R-b and applying it. Let us hereby atone for our sins: https://github.com/XanClic/qemu/commits/block I hope the spirit of christmas will make Markus forgive us. Max --PCpETbDiSV3MAXwWliNlGxO5EoCUn8Ohl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWey6FAAoJEDuxQgLoOKytsAwH/R8PFuFpFtsPwlxzibTEH/C6 rLxxovgO4Z5pw9l6KzRm1wlxuPoRVQPgavU1cy2I/8xm7yluwKO0DuRPNMscx2PC agP+YRb2qb9/uAcdQeUUGV3si2meyu9ed9YWtbYNWkCcwyG7q1aenBjbB8XE/7J9 TkDVp+W2fu6PL7o9YVqeLpMzJYm1Fpph4h0WlwcM7lGn1QocsJ/WLfQcLo5N5vjx hW5WpPwBLVXhfDveNRyQge1sD1ywQpHH1S6YLwrsaD/6Fc82yCTQjv6ehVpU1CO4 R1Ix3Zsh63suF/N+7JXwyiXnyrtiFhmstzTrcVPcvBGayHdMTNf0w8cQ7t3XjcQ= =TjXP -----END PGP SIGNATURE----- --PCpETbDiSV3MAXwWliNlGxO5EoCUn8Ohl--