* [Qemu-devel] [PATCH] block/qapi: Clear err for further error
@ 2015-12-22 10:11 Fam Zheng
2015-12-22 14:39 ` John Snow
0 siblings, 1 reply; 4+ messages in thread
From: Fam Zheng @ 2015-12-22 10:11 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, jsnow, Markus Armbruster, qemu-block, mreitz
Since a5002d5 (block/qapi: allow best-effort query) we don't return at
this error, however err must be cleared before passing to
bdrv_query_snapshot_info_list below, as required by error API.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/qapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qapi.c b/block/qapi.c
index fecac25..58d3975 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -250,6 +250,7 @@ void bdrv_query_image_info(BlockDriverState *bs,
g_free(backing_filename2);
backing_filename2 = NULL;
error_free(err);
+ err = NULL;
}
/* Always report the full_backing_filename if present, even if it's the
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] block/qapi: Clear err for further error
2015-12-22 10:11 [Qemu-devel] [PATCH] block/qapi: Clear err for further error Fam Zheng
@ 2015-12-22 14:39 ` John Snow
2015-12-23 23:30 ` Max Reitz
0 siblings, 1 reply; 4+ messages in thread
From: John Snow @ 2015-12-22 14:39 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Kevin Wolf, Markus Armbruster, qemu-block, mreitz
On 12/22/2015 05:11 AM, Fam Zheng wrote:
> Since a5002d5 (block/qapi: allow best-effort query) we don't return at
> this error, however err must be cleared before passing to
> bdrv_query_snapshot_info_list below, as required by error API.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/qapi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/qapi.c b/block/qapi.c
> index fecac25..58d3975 100644
> --- a/block/qapi.c
> +++ b/block/qapi.c
> @@ -250,6 +250,7 @@ void bdrv_query_image_info(BlockDriverState *bs,
> g_free(backing_filename2);
> backing_filename2 = NULL;
> error_free(err);
> + err = NULL;
> }
>
> /* Always report the full_backing_filename if present, even if it's the
>
Sorry Markus, I've failed you.
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block/qapi: Clear err for further error
2015-12-22 14:39 ` John Snow
@ 2015-12-23 23:30 ` Max Reitz
2016-01-11 15:41 ` Markus Armbruster
0 siblings, 1 reply; 4+ messages in thread
From: Max Reitz @ 2015-12-23 23:30 UTC (permalink / raw)
To: John Snow, Fam Zheng, qemu-devel
Cc: Kevin Wolf, Markus Armbruster, qemu-block
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
On 22.12.2015 15:39, John Snow wrote:
>
>
> On 12/22/2015 05:11 AM, Fam Zheng wrote:
>> Since a5002d5 (block/qapi: allow best-effort query) we don't return at
>> this error, however err must be cleared before passing to
>> bdrv_query_snapshot_info_list below, as required by error API.
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>> ---
>> block/qapi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/block/qapi.c b/block/qapi.c
>> index fecac25..58d3975 100644
>> --- a/block/qapi.c
>> +++ b/block/qapi.c
>> @@ -250,6 +250,7 @@ void bdrv_query_image_info(BlockDriverState *bs,
>> g_free(backing_filename2);
>> backing_filename2 = NULL;
>> error_free(err);
>> + err = NULL;
>> }
>>
>> /* Always report the full_backing_filename if present, even if it's the
>>
>
> Sorry Markus, I've failed you.
>
> Reviewed-by: John Snow <jsnow@redhat.com>
As did I by giving an R-b and applying it.
Let us hereby atone for our sins:
https://github.com/XanClic/qemu/commits/block
I hope the spirit of christmas will make Markus forgive us.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block/qapi: Clear err for further error
2015-12-23 23:30 ` Max Reitz
@ 2016-01-11 15:41 ` Markus Armbruster
0 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2016-01-11 15:41 UTC (permalink / raw)
To: Max Reitz; +Cc: Kevin Wolf, Fam Zheng, John Snow, qemu-devel, qemu-block
Max Reitz <mreitz@redhat.com> writes:
> On 22.12.2015 15:39, John Snow wrote:
>>
>>
>> On 12/22/2015 05:11 AM, Fam Zheng wrote:
>>> Since a5002d5 (block/qapi: allow best-effort query) we don't return at
>>> this error, however err must be cleared before passing to
>>> bdrv_query_snapshot_info_list below, as required by error API.
>>>
>>> Signed-off-by: Fam Zheng <famz@redhat.com>
>>> ---
>>> block/qapi.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/block/qapi.c b/block/qapi.c
>>> index fecac25..58d3975 100644
>>> --- a/block/qapi.c
>>> +++ b/block/qapi.c
>>> @@ -250,6 +250,7 @@ void bdrv_query_image_info(BlockDriverState *bs,
>>> g_free(backing_filename2);
>>> backing_filename2 = NULL;
>>> error_free(err);
>>> + err = NULL;
>>> }
>>>
>>> /* Always report the full_backing_filename if present, even if it's the
>>>
>>
>> Sorry Markus, I've failed you.
There, for the grace of God, go I.
>> Reviewed-by: John Snow <jsnow@redhat.com>
>
> As did I by giving an R-b and applying it.
>
> Let us hereby atone for our sins:
>
> https://github.com/XanClic/qemu/commits/block
>
>
> I hope the spirit of christmas will make Markus forgive us.
Happy new year!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-11 15:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-22 10:11 [Qemu-devel] [PATCH] block/qapi: Clear err for further error Fam Zheng
2015-12-22 14:39 ` John Snow
2015-12-23 23:30 ` Max Reitz
2016-01-11 15:41 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).