From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBtZB-0006GK-90 for qemu-devel@nongnu.org; Wed, 23 Dec 2015 19:15:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBtZA-0002oB-IU for qemu-devel@nongnu.org; Wed, 23 Dec 2015 19:15:37 -0500 References: <1450843928-15380-1-git-send-email-famz@redhat.com> <1450843928-15380-2-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <567B391E.9080101@redhat.com> Date: Thu, 24 Dec 2015 01:15:26 +0100 MIME-Version: 1.0 In-Reply-To: <1450843928-15380-2-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jXUxulVBNhtidVMcNACfpkRWsUiR34ghQ" Subject: Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Jeff Cody , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jXUxulVBNhtidVMcNACfpkRWsUiR34ghQ Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 23.12.2015 05:12, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. >=20 > Rewrite mirror_iteration to fix both flaws. >=20 > Signed-off-by: Fam Zheng > --- > block/mirror.c | 308 +++++++++++++++++++++++++++++++++++--------------= -------- > 1 file changed, 188 insertions(+), 120 deletions(-) Reviewed-by: Max Reitz --jXUxulVBNhtidVMcNACfpkRWsUiR34ghQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWezkeAAoJEDuxQgLoOKytMu4IAIzN6LLux19RZC0SmRXepqR1 Kh0K5i0Y1ieO/o/FaOsgtlm/mJXcR8uXDFv2jjIebuhLAxZDrJ/BCtvdkM3jhytf cyhTw9JpZNkfyeU1hb46Wtc8nyjbgrPEiTG0WICmlI1G9G1jy4b6yftfMqBHDIAa OZ5MIb3z0jXHkOke0xDqFsgNiaZTFDFl/q023VxG6FRyCYm4qPimr1ZPgAWQ4B1r chS2S9ETuMazahl0MWoM/QRfh28dZ7FJVwIawP+8Wde2i/baq84jOsDUrG42NBrA Yh/p8IS1uyr65PCo7iZ1EcdtbZeouG5CSGYBgNUjjOc0kKwggUe4iiSRog6gPJI= =61Ah -----END PGP SIGNATURE----- --jXUxulVBNhtidVMcNACfpkRWsUiR34ghQ--