From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
pbonzini@redhat.com, Jeff Cody <jcody@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration
Date: Thu, 24 Dec 2015 01:21:10 +0100 [thread overview]
Message-ID: <567B3A76.2000602@redhat.com> (raw)
In-Reply-To: <567B391E.9080101@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On 24.12.2015 01:15, Max Reitz wrote:
> On 23.12.2015 05:12, Fam Zheng wrote:
>> The "pnum < nb_sectors" condition in deciding whether to actually copy
>> data is unnecessarily strict, and the qiov initialization is
>> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard.
>>
>> Rewrite mirror_iteration to fix both flaws.
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>> ---
>> block/mirror.c | 308 +++++++++++++++++++++++++++++++++++----------------------
>> 1 file changed, 188 insertions(+), 120 deletions(-)
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
Forgot to note: I think this patch needs a rebase already.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-12-24 0:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 4:12 [Qemu-devel] [PATCH v7 0/2] mirror: Improve zero write and discard Fam Zheng
2015-12-23 4:12 ` [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration Fam Zheng
2015-12-24 0:15 ` Max Reitz
2015-12-24 0:21 ` Max Reitz [this message]
2015-12-24 2:54 ` Fam Zheng
2015-12-23 4:12 ` [Qemu-devel] [PATCH v7 2/2] mirror: Add mirror_wait_for_io Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567B3A76.2000602@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).