From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBtem-0007Re-LS for qemu-devel@nongnu.org; Wed, 23 Dec 2015 19:21:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBtel-0003gd-Q9 for qemu-devel@nongnu.org; Wed, 23 Dec 2015 19:21:24 -0500 References: <1450843928-15380-1-git-send-email-famz@redhat.com> <1450843928-15380-2-git-send-email-famz@redhat.com> <567B391E.9080101@redhat.com> From: Max Reitz Message-ID: <567B3A76.2000602@redhat.com> Date: Thu, 24 Dec 2015 01:21:10 +0100 MIME-Version: 1.0 In-Reply-To: <567B391E.9080101@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Nnn3WGX5383soeoqnFO5LBPMfTQsHUqE8" Subject: Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Jeff Cody , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Nnn3WGX5383soeoqnFO5LBPMfTQsHUqE8 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 24.12.2015 01:15, Max Reitz wrote: > On 23.12.2015 05:12, Fam Zheng wrote: >> The "pnum < nb_sectors" condition in deciding whether to actually copy= >> data is unnecessarily strict, and the qiov initialization is >> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. >> >> Rewrite mirror_iteration to fix both flaws. >> >> Signed-off-by: Fam Zheng >> --- >> block/mirror.c | 308 +++++++++++++++++++++++++++++++++++-------------= --------- >> 1 file changed, 188 insertions(+), 120 deletions(-) >=20 > Reviewed-by: Max Reitz Forgot to note: I think this patch needs a rebase already. Max --Nnn3WGX5383soeoqnFO5LBPMfTQsHUqE8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWezp2AAoJEDuxQgLoOKytjWkH/3wtCLsRm5DOM0hK67C0IJ+c 5hoqKqpdC3NswHhwJULcqgyJ4czT20kMfKZz/QUezUBYgUdKMSVxmdGT/v40ab8q 4EYqJtRpBafoXFkreh+OdwY6c0GNfEGBzmpbDeC5jzVtpizevE/dpVf+4NYrVjRr Vp4QJcoODJtcrXMal24nRGOd1KaFoWD9DLWRyuRVinQhwh6HSLVLd2CRRgJsE5Nh g9GLDgVPkUvtUw5YlJ8BOuIAgXE/x1gwVdCFikdLIPCofp87paMufzUp5qii+u4l aC11btu6Gz+bkpumrU65KkrpW+6P5nHWvF+eippsp1ppWovEBLDdyvIu0jHNNYo= =K6S4 -----END PGP SIGNATURE----- --Nnn3WGX5383soeoqnFO5LBPMfTQsHUqE8--