From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBtkG-0002LK-3K for qemu-devel@nongnu.org; Wed, 23 Dec 2015 19:27:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBtkF-0005BE-Ao for qemu-devel@nongnu.org; Wed, 23 Dec 2015 19:27:04 -0500 References: <1450850347-5291-1-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <567B3BCD.9060309@redhat.com> Date: Thu, 24 Dec 2015 01:26:53 +0100 MIME-Version: 1.0 In-Reply-To: <1450850347-5291-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NIWrHlwWn99PQ5FwAF13Fitx1vMm4aej6" Subject: Re: [Qemu-devel] [PATCH v3 0/5] qmp: Add blockdev-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , Markus Armbruster , Stefan Hajnoczi , pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NIWrHlwWn99PQ5FwAF13Fitx1vMm4aej6 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 23.12.2015 06:59, Fam Zheng wrote: > v3: Rebase to master. Why did you drop patch 1? Max > v2: 01: Move bdrv_op_block_all down. [Max] > 02, 04: Add Max's rev-by. > 03: Check has_mode and fix "return;". [Max] > 05: Check target->blk. > Drop superfluous whitespace. [Max] > 06: Drop superfluous whitespace hunk and add Max's rev-by. [Max] >=20 > This is the counterpart of blockdev-backup. The biggest value of this c= ommand > is to allow full flexibility on target image open options, via blockdev= -add. > For example this could help solve the target provisioning issue in: >=20 > http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg02139.html >=20 >=20 >=20 > Fam Zheng (5): > block: Rename BLOCK_OP_TYPE_MIRROR to BLOCK_OP_TYPE_MIRROR_SOURCE > block: Extract blockdev part of qmp_drive_mirror > block: Add check on mirror target > qmp: Add blockdev-mirror command > iotests: Add test cases for blockdev-mirror >=20 > blockdev.c | 179 ++++++++++++++++++++++++++++++--= -------- > hw/block/dataplane/virtio-blk.c | 2 +- > include/block/block.h | 3 +- > qapi/block-core.json | 47 +++++++++++ > qmp-commands.hx | 48 +++++++++++ > tests/qemu-iotests/041 | 100 ++++++++++++++++------ > tests/qemu-iotests/041.out | 4 +- > 7 files changed, 314 insertions(+), 69 deletions(-) >=20 --NIWrHlwWn99PQ5FwAF13Fitx1vMm4aej6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWezvNAAoJEDuxQgLoOKytzC8H/i5QNtSJ3HhnE42GamrS4Yrz HZHrcx1xKqIYSLi3UjsN+vZXtD5bnYPHAqwn5AVmQGO+tIhTQbYPpMRFtYQTclgf e2JwDKQ3OxPVJdU6QPOrodYll/N8+bt+MBeMF1vmF21ITNz/6u/ZPfw6QM+Ptc13 zqkH+k7ZKn9R38SiBCLaAs1JIR6hPH7N9iR37HlBzjd1ya04vGttG4T3Icmh+Iko iUZWAsldF70PA/gjYkFIomJx/dqx/X9RjJSYJ4MzU56VEhQnwV1+CMnHwxYCkw2V lPKNwGFrS2OqQ8Q/zUmPp6ueumKVnOWYQLvDGCm+tFAFXxUU+ZQ9JX3qr1bLLQU= =he+A -----END PGP SIGNATURE----- --NIWrHlwWn99PQ5FwAF13Fitx1vMm4aej6--